Re: [PATCH 3/7] cxgb3 - FW version update

2007-02-25 Thread Divy Le Ray
Jeff Garzik wrote: Steve Wise wrote: I would rather fix the code to use constants, and thus avoid this problem ever happening again. Jeff How's this (not tested)? seems OK to me I tested it and resubmitted. Thanks fro the fix suggestion and the patch! Cheers, Divy - To unsubscribe

Re: [PATCH 3/7] cxgb3 - FW version update

2007-02-25 Thread Jeff Garzik
Steve Wise wrote: I would rather fix the code to use constants, and thus avoid this problem ever happening again. Jeff How's this (not tested)? seems OK to me - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] M

Re: [PATCH 3/7] cxgb3 - FW version update

2007-02-25 Thread Steve Wise
> I would rather fix the code to use constants, and thus avoid this > problem ever happening again. > > Jeff > How's this (not tested)? --- drivers/net/cxgb3/t3_hw.c |6 -- drivers/net/cxgb3/version.h |2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a

Re: [PATCH 3/7] cxgb3 - FW version update

2007-02-25 Thread Jeff Garzik
Steve Wise wrote: Hey Divy, You missed a printk change. Here is an updated patch. Update FW version to 3.2 Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/net/cxgb3/t3_hw.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/cxgb3/

Re: [PATCH 3/7] cxgb3 - FW version update

2007-02-25 Thread Steve Wise
Hey Divy, You missed a printk change. Here is an updated patch. Update FW version to 3.2 Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/net/cxgb3/t3_hw.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/cxgb3/t3_hw.c b/drivers/ne