Re: [PATCH 3/7] uprobes/x86: Conditionalize the usage of handle_riprel_insn()

2014-04-02 Thread Oleg Nesterov
On 04/02, Jim Keniston wrote: > > On Tue, 2014-04-01 at 18:39 +0200, Oleg Nesterov wrote: > > > So let me explain the problem, and how (I think) it should be solved. > > Unfortunately, I do not even know the terminology, so firstly I have > > to explain you the things I recently learned when I inve

Re: [PATCH 3/7] uprobes/x86: Conditionalize the usage of handle_riprel_insn()

2014-04-02 Thread Jim Keniston
On Tue, 2014-04-01 at 18:39 +0200, Oleg Nesterov wrote: > On 04/01, Oleg Nesterov wrote: > > > > Good point, I'll send v2. > > Masami, et al, I was going to send v2 plus the next short RFC series > which fixes the problem today, but it turns out that I have no time. > Will try to do this tomorrow.

Re: [PATCH 3/7] uprobes/x86: Conditionalize the usage of handle_riprel_insn()

2014-04-01 Thread Oleg Nesterov
On 04/01, Oleg Nesterov wrote: > > Good point, I'll send v2. Masami, et al, I was going to send v2 plus the next short RFC series which fixes the problem today, but it turns out that I have no time. Will try to do this tomorrow. So let me explain the problem, and how (I think) it should be solved

Re: [PATCH 3/7] uprobes/x86: Conditionalize the usage of handle_riprel_insn()

2014-04-01 Thread Oleg Nesterov
On 04/01, Masami Hiramatsu wrote: > > (2014/04/01 4:44), Oleg Nesterov wrote: > > arch_uprobe_analyze_insn() calls handle_riprel_insn() at the start, > > but only "0xff" and "default" cases need the UPROBE_FIX_RIP_ logic. > > Move the callsite into "default" case and change the "0xff" case to > > f

Re: [PATCH 3/7] uprobes/x86: Conditionalize the usage of handle_riprel_insn()

2014-03-31 Thread Masami Hiramatsu
(2014/04/01 4:44), Oleg Nesterov wrote: > arch_uprobe_analyze_insn() calls handle_riprel_insn() at the start, > but only "0xff" and "default" cases need the UPROBE_FIX_RIP_ logic. > Move the callsite into "default" case and change the "0xff" case to > fall-through. > > We are going to add the vari