Re: [PATCH 4/4][RESEND] readahead: cleanup blockable_page_cache_readahead()

2005-02-24 Thread Steven Pratt
Ram wrote: Andrew, I have verified the patches against my standard benchmarks and did not see any bad effects. Also I have reviewd the patch and it looked clean and correct. RP I have not had a chance to benchmark, but visual inspection looks good. Steve On Thu, 2005-02-24 at 11:37,

Re: [PATCH 4/4][RESEND] readahead: cleanup blockable_page_cache_readahead()

2005-02-24 Thread Ram
Andrew, I have verified the patches against my standard benchmarks and did not see any bad effects. Also I have reviewd the patch and it looked clean and correct. RP On Thu, 2005-02-24 at 11:37, Oleg Nesterov wrote: > I think that do_page_cache_readahead() can be inlined