Re: [PATCH 4/4] Add support for SUNIX Multi-I/O board

2019-04-02 Thread Lee Jones
Please do not drop the list from your recipients. On Tue, 02 Apr 2019, Morris Ku 古文俊 wrote: > Hello , Lee , > > > Sunix multi-io card is a composite device, > contains serial and parallel port , before we > trying to place the driver in the /drivers/char, > but maintainer suggests go to /driver

Re: [PATCH 4/4] Add support for SUNIX Multi-I/O board

2019-04-01 Thread Lee Jones
On Tue, 19 Mar 2019, Morris Ku wrote: > Driver for SUNIX Multi-I/O card.Based on parport_pc.c, ppdev.c > and lp.c by Linus Torvalds, Theodore Ts'o. Parallel port drivers should live in 'drivers/parport' and 'drivers/char'. LP drivers should live in 'drivers/char'. Please them there. > Signed-o

Re: [PATCH 4/4] Add support for SUNIX Multi-I/O board

2019-03-22 Thread Enrico Weigelt, metux IT consult
On 19.03.19 13:08, Morris Ku wrote: > diff --git a/mfd/sunix/snx_ieee1284_ops.c b/mfd/sunix/snx_ieee1284_ops.c > new file mode 100644 > index ..2dac03fd > --- /dev/null > +size_t sunix_parport_ieee1284_read_nibble(struct snx_parport *port, > +void *buffer, size_t len, int flags) > +{ >