Re: [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support

On Mon, Aug 19, 2013 at 07:12:38PM +0200, Sebastian Andrzej Siewior wrote: > * Zubair Lutfullah | 2013-08-13 21:05:03 [+0100]: > > >diff --git a/drivers/iio/adc/ti_am335x_adc.c > >b/drivers/iio/adc/ti_am335x_adc.c > >index 3ceac3e..0d7e313 100644 > >--- a/drivers/iio/adc/ti_am335x_adc.c > >+++ b/

Re: [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support

* Zubair Lutfullah | 2013-08-13 21:05:03 [+0100]: >diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c >index 3ceac3e..0d7e313 100644 >--- a/drivers/iio/adc/ti_am335x_adc.c >+++ b/drivers/iio/adc/ti_am335x_adc.c … >+static irqreturn_t tiadc_irq(int irq, void *private) >+

Re: [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support

On Thu, Aug 15, 2013 at 12:43:02PM +0100, Jonathan Cameron wrote: > Note I'd also like a much more detailed description in the patch header. > > I would also expect an option for the trigger to be supplied from the > chip itself based on fifo watershead interrupts. Thus the adc could be > operate

Re: [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support

On Fri, Aug 16, 2013 at 02:53:40PM +0200, Sebastian Andrzej Siewior wrote: > * Zubair Lutfullah | 2013-08-13 21:05:03 [+0100]: > > >diff --git a/drivers/iio/adc/ti_am335x_adc.c > >b/drivers/iio/adc/ti_am335x_adc.c > >index 3ceac3e..0d7e313 100644 > >--- a/drivers/iio/adc/ti_am335x_adc.c > >+++ b/

Re: [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support

On Fri, Aug 16, 2013 at 12:46:31PM +0200, Sebastian Andrzej Siewior wrote: > On 08/16/2013 01:33 PM, Jonathan Cameron wrote: > > Ah, fixes-togreg is for this cycle, whereas new stuff like this needs > > to go on the togreg branch. Hence please rebase on the togreg branch > > instead. > > But he n

Re: [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support

On Fri, Aug 16, 2013 at 03:25:49PM +0200, Sebastian Andrzej Siewior wrote: > * Zubair Lutfullah | 2013-08-13 21:05:03 [+0100]: > > >diff --git a/drivers/iio/adc/ti_am335x_adc.c > >b/drivers/iio/adc/ti_am335x_adc.c > >index 3ceac3e..0d7e313 100644 > >--- a/drivers/iio/adc/ti_am335x_adc.c > >+++ b/

Re: [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support

On Fri, Aug 16, 2013 at 04:59:49PM +0200, Sebastian Andrzej Siewior wrote: > * Zubair Lutfullah | 2013-08-13 21:05:03 [+0100]: > > >diff --git a/drivers/iio/adc/ti_am335x_adc.c > >b/drivers/iio/adc/ti_am335x_adc.c > >index 3ceac3e..0d7e313 100644 > >--- a/drivers/iio/adc/ti_am335x_adc.c > >+++ b/

Re: [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support

* Zubair Lutfullah | 2013-08-13 21:05:03 [+0100]: >diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c >index 3ceac3e..0d7e313 100644 >--- a/drivers/iio/adc/ti_am335x_adc.c >+++ b/drivers/iio/adc/ti_am335x_adc.c … >+static int tiadc_buffer_postdisable(struct iio_dev *in

Re: [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support

* Zubair Lutfullah | 2013-08-13 21:05:03 [+0100]: >diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c >index 3ceac3e..0d7e313 100644 >--- a/drivers/iio/adc/ti_am335x_adc.c >+++ b/drivers/iio/adc/ti_am335x_adc.c >@@ -141,58 +350,51 @@ static int tiadc_read_raw(struct iio

Re: [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support

* Zubair Lutfullah | 2013-08-13 21:05:03 [+0100]: >diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c >index 3ceac3e..0d7e313 100644 >--- a/drivers/iio/adc/ti_am335x_adc.c >+++ b/drivers/iio/adc/ti_am335x_adc.c >@@ -24,16 +24,28 @@ … >+static irqreturn_t tiadc_irq(int i

Re: [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support

On 08/16/2013 01:33 PM, Jonathan Cameron wrote: > Ah, fixes-togreg is for this cycle, whereas new stuff like this needs > to go on the togreg branch. Hence please rebase on the togreg branch > instead. But he needs "iio: ti_am335x_adc: Fix wrong samples received on 1st read" from that branch. How

Re: [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support

On 08/16/13 11:07, Sebastian Andrzej Siewior wrote: > * Jonathan Cameron | 2013-08-15 12:43:02 [+0100]: > >> Hi, > Hi Jonathan, > >> Whilst the below review is based on what we have here, I tried to apply it >> to the latest iio.git togreg branch (which for this driver should be >> much the same

Re: [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support

* Sebastian Andrzej Siewior | 2013-08-16 12:07:02 [+0200]: >* Jonathan Cameron | 2013-08-15 12:43:02 [+0100]: > >It did apply with no trouble here. and with diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index 93129ec..fdd9810 100644 --- a/drivers/iio/adc/Kconfig +++ b/drivers/ii

Re: [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support

* Jonathan Cameron | 2013-08-15 12:43:02 [+0100]: >Hi, Hi Jonathan, >Whilst the below review is based on what we have here, I tried to apply it >to the latest iio.git togreg branch (which for this driver should be >much the same as staging-next and hence linux-next). It's not even >close and I c

Re: [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support

On 08/13/13 21:05, Zubair Lutfullah wrote: > Previously the driver had only one-shot reading functionality. > This patch adds triggered buffer support to the driver. > A buffer of samples can now be read via /dev/iio. > Any IIO trigger can be used to start acquisition. > > Patil Rachna (TI) laid th

Re: [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support

On Tue, 13 Aug 2013, Zubair Lutfullah wrote: > Previously the driver had only one-shot reading functionality. > This patch adds triggered buffer support to the driver. > A buffer of samples can now be read via /dev/iio. > Any IIO trigger can be used to start acquisition. > > Patil Rachna (TI) lai