Re: [PATCH 4/4] misc: hpilo: Update driver version

2019-02-25 Thread Greg KH
On Mon, Feb 25, 2019 at 01:28:05AM -0700, Jerry Hoemann wrote: > On Fri, Feb 22, 2019 at 07:49:28AM +0100, Greg KH wrote: > > On Thu, Feb 21, 2019 at 09:11:11PM -0700, Jerry Hoemann wrote: > > > > > Our primary means of supporting Linux to our customers is via our > > > distro partners. While we

Re: [PATCH 4/4] misc: hpilo: Update driver version

2019-02-25 Thread Jerry Hoemann
On Fri, Feb 22, 2019 at 07:49:28AM +0100, Greg KH wrote: > On Thu, Feb 21, 2019 at 09:11:11PM -0700, Jerry Hoemann wrote: > > > Our primary means of supporting Linux to our customers is via our > > distro partners. While we prefer to use in distro drivers, HPE does > > from time to time deliver d

Re: [PATCH 4/4] misc: hpilo: Update driver version

2019-02-21 Thread Greg KH
On Thu, Feb 21, 2019 at 09:11:11PM -0700, Jerry Hoemann wrote: > On Thu, Feb 21, 2019 at 09:32:56AM +0100, Greg KH wrote: > ... > > > > > > -MODULE_VERSION("1.5.0"); > > > +MODULE_VERSION("1.5.1"); > > > > This line means nothing, it should just be removed entirely. The > > "version" of the dri

Re: [PATCH 4/4] misc: hpilo: Update driver version

2019-02-21 Thread Jerry Hoemann
On Thu, Feb 21, 2019 at 09:32:56AM +0100, Greg KH wrote: ... > > > > -MODULE_VERSION("1.5.0"); > > +MODULE_VERSION("1.5.1"); > > This line means nothing, it should just be removed entirely. The > "version" of the driver is the kernel version itself. Hi Greg, This doesn't hold when we do drive

Re: [PATCH 4/4] misc: hpilo: Update driver version

2019-02-21 Thread Greg KH
On Thu, Feb 21, 2019 at 04:04:42PM +0800, Matt Hsiao wrote: > Bump version number to reflect recent minor changes. > > Signed-off-by: Matt Hsiao > --- > drivers/misc/hpilo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/hpilo.c b/drivers/misc/hpilo.c > in