Re: [PATCH 4/4] uprobes: __replace_page() needs munlock_vma_page()

2012-07-26 Thread Oleg Nesterov
On 07/26, Srikar Dronamraju wrote: > > * Oleg Nesterov [2012-07-12 19:10:25]: > > > Like do_wp_page(), __replace_page() should do munlock_vma_page() > > for the case when the old page still has other !VM_LOCKED mappings. > > Unfortunately this needs mm/internal.h. > > > > Also, move put_page() out

Re: [PATCH 4/4] uprobes: __replace_page() needs munlock_vma_page()

2012-07-25 Thread Srikar Dronamraju
* Oleg Nesterov [2012-07-12 19:10:25]: > Like do_wp_page(), __replace_page() should do munlock_vma_page() > for the case when the old page still has other !VM_LOCKED mappings. > Unfortunately this needs mm/internal.h. > > Also, move put_page() outside of ptl lock. This doesn't really > matter bu