Re: [PATCH 4/4] x86_64 ioapic: Improve the heuristics for when check_timer fails.

2007-01-10 Thread Tobias Diedrich
bject: Re: [PATCH 4/4] x86_64 ioapic: Improve the heuristics for when > check_timer fails. > > > >Works fine with BIOS 0402. > > >x86_64_io_apic_fix_eric_20060108 > > >..TIMER: vector=0x20 apic1=0 pin1=0 apic2=-1 pin2=-1 > >..TIMER trying IO-APIC=0 PIN=0<

RE: [PATCH 4/4] x86_64 ioapic: Improve the heuristics for when check_timer fails.

2007-01-09 Thread Lu, Yinghai
-Original Message- From: Tobias Diedrich [mailto:[EMAIL PROTECTED] Sent: Tuesday, January 09, 2007 2:01 PM To: Eric W. Biederman Cc: Linus Torvalds; Lu, Yinghai; Andrew Morton; Adrian Bunk; Andi Kleen; Linux Kernel Mailing List Subject: Re: [PATCH 4/4] x86_64 ioapic: Improve the

Re: [PATCH 4/4] x86_64 ioapic: Improve the heuristics for when check_timer fails.

2007-01-09 Thread Tobias Diedrich
Eric W. Biederman wrote: > Tobias. I don't have a box with the problem yours does, and this > doesn't quite try any of the cases you have been asked to test > so could you please test this one? Works fine with BIOS 0402. patches/series: patch-2.6.20-rc4 patch-2.6.19-rc3-nokmem myconfig ccache x8

Re: [PATCH 4/4] x86_64 ioapic: Improve the heuristics for when check_timer fails.

2007-01-08 Thread Eric W. Biederman
Adrian Bunk <[EMAIL PROTECTED]> writes: > On Mon, Jan 08, 2007 at 02:45:00PM -0700, Eric W. Biederman wrote: >> Adrian Bunk <[EMAIL PROTECTED]> writes: > > We just got a completely different bug reported that was confirmed to be > caused by Andi's patch: >AMD64/ATI : timer is running twice as

Re: [PATCH 4/4] x86_64 ioapic: Improve the heuristics for when check_timer fails.

2007-01-08 Thread Linus Torvalds
On Mon, 8 Jan 2007, Adrian Bunk wrote: > > We just got a completely different bug reported that was confirmed to be > caused by Andi's patch: >AMD64/ATI : timer is running twice as fast as it should [1] Yeah. I have to say, that with my main goal for 2.6.20 being a stability release, and

Re: [PATCH 4/4] x86_64 ioapic: Improve the heuristics for when check_timer fails.

2007-01-08 Thread Adrian Bunk
On Mon, Jan 08, 2007 at 02:45:00PM -0700, Eric W. Biederman wrote: > Adrian Bunk <[EMAIL PROTECTED]> writes: > > > On Mon, Jan 08, 2007 at 09:11:24AM -0700, Eric W. Biederman wrote: > >> > >> To a large extent this reverts b026872601976f666bae77b609dc490d1834bf77 > >> while still keeping to the s

Re: [PATCH 4/4] x86_64 ioapic: Improve the heuristics for when check_timer fails.

2007-01-08 Thread Adrian Bunk
On Mon, Jan 08, 2007 at 09:11:24AM -0700, Eric W. Biederman wrote: > > To a large extent this reverts b026872601976f666bae77b609dc490d1834bf77 > while still keeping to the spirits of it's goal, the ability to > make smart guesses about how the timer irq is routed when the BIOS > gets it wrong. >..

Re: [PATCH 4/4] x86_64 ioapic: Improve the heuristics for when check_timer fails.

2007-01-08 Thread Eric W. Biederman
Adrian Bunk <[EMAIL PROTECTED]> writes: > On Mon, Jan 08, 2007 at 09:11:24AM -0700, Eric W. Biederman wrote: >> >> To a large extent this reverts b026872601976f666bae77b609dc490d1834bf77 >> while still keeping to the spirits of it's goal, the ability to >> make smart guesses about how the timer i

Re: [PATCH 4/4] x86_64 ioapic: Improve the heuristics for when check_timer fails.

2007-01-08 Thread Eric W. Biederman
"Lu, Yinghai" <[EMAIL PROTECTED]> writes: >>So that doesn't invalidate the generic test. I'm going to go dig >>out what little information I have and see if I can stair at the >>register definition. > > Someone said we can that info about that reg in Kernel. And only > firmware can use that. We

RE: [PATCH 4/4] x86_64 ioapic: Improve the heuristics for when check_timer fails.

2007-01-08 Thread Lu, Yinghai
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Monday, January 08, 2007 12:47 PM To: Lu, Yinghai Cc: Linus Torvalds; Tobias Diedrich; Andrew Morton; Adrian Bunk; Andi Kleen; Linux Kernel Mailing List Subject: Re: [PATCH 4/4] x86_64 ioapic: Improve the

Re: [PATCH 4/4] x86_64 ioapic: Improve the heuristics for when check_timer fails.

2007-01-08 Thread Eric W. Biederman
"Lu, Yinghai" <[EMAIL PROTECTED]> writes: > >>I have tested this on an Nvidia board that reports that apic 0 pin 2 >>works when it does not and this code successfully programs apic 0 pin 0 >>into ExtINT mode. > > For some CK804 boards, BIOS forget set to 8254 timer to apic0/pin2, and > still leave

Re: [PATCH 4/4] x86_64 ioapic: Improve the heuristics for when check_timer fails.

2007-01-08 Thread Eric W. Biederman
"Lu, Yinghai" <[EMAIL PROTECTED]> writes: >>+static int check_timer_pin(int apic, int pin) >>+{ >>+ int irq, idx; >>+ /* >>+ * Test the architecture default i8254 timer pin >>+ * of apic 0 pin 2. >>+ */ > > Comments need to be updated. Probably. Although this is all I ha

RE: [PATCH 4/4] x86_64 ioapic: Improve the heuristics for when check_timer fails.

2007-01-08 Thread Lu, Yinghai
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Monday, January 08, 2007 8:11 AM To: Linus Torvalds Cc: Tobias Diedrich; Lu, Yinghai; Andrew Morton; Adrian Bunk; Andi Kleen; Linux Kernel Mailing List Subject: [PATCH 4/4] x86_64 ioapic: Improve the heuristics for

RE: [PATCH 4/4] x86_64 ioapic: Improve the heuristics for when check_timer fails.

2007-01-08 Thread Lu, Yinghai
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Monday, January 08, 2007 8:11 AM To: Linus Torvalds Cc: Tobias Diedrich; Lu, Yinghai; Andrew Morton; Adrian Bunk; Andi Kleen; Linux Kernel Mailing List Subject: [PATCH 4/4] x86_64 ioapic: Improve the heuristics for