Re: [PATCH 4/5] coresight-stm: adding driver for CoreSight STM component

2015-04-01 Thread Mathieu Poirier
+ Al Grant On 1 April 2015 at 08:27, Mathieu Poirier wrote: > Adding Al Grant to the conversation - his knowledge on HW tracing for > the ARM architecture is definitely an asset for this kind of planning. > Please add him to future patchset as well. > > On 31 March 2015 at 09:04, Alexander Shishk

Re: [PATCH 4/5] coresight-stm: adding driver for CoreSight STM component

2015-04-01 Thread Mathieu Poirier
Adding Al Grant to the conversation - his knowledge on HW tracing for the ARM architecture is definitely an asset for this kind of planning. Please add him to future patchset as well. On 31 March 2015 at 09:04, Alexander Shishkin wrote: > Mathieu Poirier writes: > >> On 30 March 2015 at 08:04, A

Re: [PATCH 4/5] coresight-stm: adding driver for CoreSight STM component

2015-03-31 Thread Alexander Shishkin
Mathieu Poirier writes: > On 30 March 2015 at 08:04, Alexander Shishkin > wrote: >> As it looks from the above snippet, you're using a stream of DATA >> packets for user's payload. I also noticed that you use an ioctl to >> trigger timestamps. > > Right, the ioctl() conveys user space intentions

Re: [PATCH 4/5] coresight-stm: adding driver for CoreSight STM component

2015-03-30 Thread Mathieu Poirier
On 30 March 2015 at 08:04, Alexander Shishkin wrote: > Mathieu Poirier writes: > >> +static int stm_send(void *addr, const void *data, u32 size) >> +{ >> + u32 len = size; >> + >> + if (((unsigned long)data & 0x1) && (size >= 1)) { >> + writeb_relaxed(*(u8 *)data, addr); >> +

Re: [PATCH 4/5] coresight-stm: adding driver for CoreSight STM component

2015-03-30 Thread Alexander Shishkin
Mathieu Poirier writes: > +static int stm_send(void *addr, const void *data, u32 size) > +{ > + u32 len = size; > + > + if (((unsigned long)data & 0x1) && (size >= 1)) { > + writeb_relaxed(*(u8 *)data, addr); > + data++; > + size--; > + } > + if

Re: [PATCH 4/5] coresight-stm: adding driver for CoreSight STM component

2015-03-07 Thread Alexander Shishkin
Mathieu Poirier writes: > From: Pratik Patel > > This driver adds support for the STM CoreSight IP block, > allowing any system compoment (HW or SW) to log and > aggregate messages via a single entity. > > The STM exposes an application defined number of channels > called stimulus port. Configu