Re: [PATCH 4/5] dt-bindings: i2c: Add Mediatek MT8183 i2c binding

2018-12-17 Thread Qii Wang
On Tue, 2018-12-18 at 00:06 +0100, Wolfram Sang wrote: > > > What is "multi-user"? Why can't you add this offset to the reg-property > > > directly? > > ... > > > MT8183 doesn't need to support muti-user according to the latest project > > information, and I'll remove this feature from patches. >

Re: [PATCH 4/5] dt-bindings: i2c: Add Mediatek MT8183 i2c binding

2018-12-17 Thread Wolfram Sang
> > What is "multi-user"? Why can't you add this offset to the reg-property > > directly? ... > MT8183 doesn't need to support muti-user according to the latest project > information, and I'll remove this feature from patches. Okay. It will be dropped then, thanks for the heads up! > > > + -

Re: [PATCH 4/5] dt-bindings: i2c: Add Mediatek MT8183 i2c binding

2018-12-13 Thread Qii Wang
On Tue, 2018-12-11 at 21:29 +0100, Wolfram Sang wrote: > > + - ch-offset: base reg offset for multi-user. > > What is "multi-user"? Why can't you add this offset to the reg-property > directly? > Thanks for your comment. There are 3 channel in one MT8183 I3C controller, and every channel can be

Re: [PATCH 4/5] dt-bindings: i2c: Add Mediatek MT8183 i2c binding

2018-12-11 Thread Wolfram Sang
> + - ch-offset: base reg offset for multi-user. What is "multi-user"? Why can't you add this offset to the reg-property directly? > + - mediatek,share-i3c: i3c controller can share i2c function. Please explain in more detail? Is this an I3C controller? signature.asc Description: PGP signa

Re: [PATCH 4/5] dt-bindings: i2c: Add Mediatek MT8183 i2c binding

2018-12-04 Thread Sean Wang
On Mon, Dec 3, 2018 at 5:34 AM wrote: > > From: qii wang > > Add MT8183 i2c binding to binding file. Compare to 2712 i2c > controller, MT8183 has different registers, offsets, clock, > and multi-user function. > > Signed-off-by: qii wang > --- > Documentation/devicetree/bindings/i2c/i2c-mtk.txt