Re: [PATCH 4/5] sock, cgroup: add sock->sk_cgroup

2015-11-17 Thread Tejun Heo
Hello, Daniel. On Tue, Nov 17, 2015 at 10:46:30PM +0100, Daniel Borkmann wrote: > Do you see a way forward where the new behavior could be enabled f.e. > as an extra mount option (that long-term would be made default, while > deprecating the current behavior) on net_cls et al? There are various >

Re: [PATCH 4/5] sock, cgroup: add sock->sk_cgroup

2015-11-17 Thread Tejun Heo
Hello, Daniel. On Tue, Nov 17, 2015 at 10:48:46PM +0100, Daniel Borkmann wrote: > >Unfortunately, sk->sk_cgrp_prioidx is an arbitrary value which can be > >configured through "net_cls.classid". :( > > Hmm, isn't net_prio independent of net_cls? Ah, yeah, I was mixing up the two but the story is

Re: [PATCH 4/5] sock, cgroup: add sock->sk_cgroup

2015-11-17 Thread Daniel Borkmann
On 11/17/2015 10:31 PM, Tejun Heo wrote: Hello, David. On Tue, Nov 17, 2015 at 04:25:54PM -0500, David Miller wrote: In preparation, this patch adds sock->sk_cgroup which points to the associated cgroup. A sock is associated on creation and stays associated to the same cgroup until freed; unfo

Re: [PATCH 4/5] sock, cgroup: add sock->sk_cgroup

2015-11-17 Thread Daniel Borkmann
Hi Tejun, On 11/17/2015 08:40 PM, Tejun Heo wrote: ... While it is possible to solve these issues from controller side by implementing hierarchical allowable ranges in both controllers, it would involve quite a bit of complexity in the controllers and further obfuscate network configuration as i

Re: [PATCH 4/5] sock, cgroup: add sock->sk_cgroup

2015-11-17 Thread David Miller
From: Tejun Heo Date: Tue, 17 Nov 2015 16:31:26 -0500 > I'll see if I can come up with a non-crazy way to combine the other > two fields with ->sk_cgroup. Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org M

Re: [PATCH 4/5] sock, cgroup: add sock->sk_cgroup

2015-11-17 Thread Tejun Heo
Hello, David. On Tue, Nov 17, 2015 at 04:25:54PM -0500, David Miller wrote: > > In preparation, this patch adds sock->sk_cgroup which points to the > > associated cgroup. A sock is associated on creation and stays > > associated to the same cgroup until freed; unfortunately, this ends up > > addi

Re: [PATCH 4/5] sock, cgroup: add sock->sk_cgroup

2015-11-17 Thread David Miller
From: Tejun Heo Date: Tue, 17 Nov 2015 14:40:39 -0500 > In preparation, this patch adds sock->sk_cgroup which points to the > associated cgroup. A sock is associated on creation and stays > associated to the same cgroup until freed; unfortunately, this ends up > adding another cgroup field to st