Re: [PATCH 4/6] drivers: hv: vmbus: Fix checkpatch SPLIT_STRING

2020-11-24 Thread Matheus Castello
Em 11/24/2020 11:56 PM, Joe Perches escreveu: On Tue, 2020-11-24 at 21:54 -0300, Matheus Castello wrote: diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c [] The above would be marginally better if organized as follows so that the main execution path isn't in an "if" clause. Als

Re: [PATCH 4/6] drivers: hv: vmbus: Fix checkpatch SPLIT_STRING

2020-11-24 Thread Joe Perches
On Tue, 2020-11-24 at 21:54 -0300, Matheus Castello wrote: > > > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c [] > > The above would be marginally better if organized as follows so that the > > main execution path isn't in an "if" clause. Also reduces indentation. > > > > hv_p

Re: [PATCH 4/6] drivers: hv: vmbus: Fix checkpatch SPLIT_STRING

2020-11-24 Thread Matheus Castello
Hi Michael, Em 11/15/2020 7:25 PM, Michael Kelley escreveu: From: Matheus Castello Sent: Sunday, November 15, 2020 11:58 AM Checkpatch emits WARNING: quoted string split across lines. To keep the code clean and with the 80 column length indentation the check and registration code for kmsg_du

RE: [PATCH 4/6] drivers: hv: vmbus: Fix checkpatch SPLIT_STRING

2020-11-15 Thread Michael Kelley
From: Matheus Castello Sent: Sunday, November 15, 2020 11:58 AM > > Checkpatch emits WARNING: quoted string split across lines. > To keep the code clean and with the 80 column length indentation the > check and registration code for kmsg_dump_register has been transferred > to a new function hv_