Re: [PATCH 4/6] include linux pci_id-h add amd northbridge defines

2007-06-13 Thread Greg KH
On Tue, Jun 12, 2007 at 10:10:58PM -0700, Doug Thompson wrote: > So is the model of such placement to locate the #define near to the > sole consumer of that item? Yes. > And if used by others, to move it to the pci_ids.h file? Yes. thanks, greg k-h - To unsubscribe from this list: send the li

Re: [PATCH 4/6] include linux pci_id-h add amd northbridge defines

2007-06-12 Thread Doug Thompson
--- Dave Jones <[EMAIL PROTECTED]> wrote: > On Mon, Jun 11, 2007 at 04:49:47PM -0700, Greg Kroah-Hartman wrote: > > On Mon, Jun 11, 2007 at 04:30:11PM -0700, Doug Thompson wrote: > > > I am working with the k8 driver and its dealing with a race with the > mcelog device as both > access > > >

Re: [PATCH 4/6] include linux pci_id-h add amd northbridge defines

2007-06-11 Thread Dave Jones
On Mon, Jun 11, 2007 at 04:49:47PM -0700, Greg Kroah-Hartman wrote: > On Mon, Jun 11, 2007 at 04:30:11PM -0700, Doug Thompson wrote: > > I am working with the k8 driver and its dealing with a race with the > > mcelog device as both access > > the K8 NB. The K8 driver does use these regs and it

Re: [PATCH 4/6] include linux pci_id-h add amd northbridge defines

2007-06-11 Thread Greg KH
On Mon, Jun 11, 2007 at 04:30:11PM -0700, Doug Thompson wrote: > > --- Greg KH <[EMAIL PROTECTED]> wrote: > > > On Fri, Jun 08, 2007 at 10:45:10AM -0600, [EMAIL PROTECTED] wrote: > > > From: Douglas Thompson <[EMAIL PROTECTED]> > > > > > > pci_ids.h needs two of the AMD NB device-ids namely,

Re: [PATCH 4/6] include linux pci_id-h add amd northbridge defines

2007-06-11 Thread Doug Thompson
--- Greg KH <[EMAIL PROTECTED]> wrote: > On Fri, Jun 08, 2007 at 10:45:10AM -0600, [EMAIL PROTECTED] wrote: > > From: Douglas Thompson <[EMAIL PROTECTED]> > > > > pci_ids.h needs two of the AMD NB device-ids namely, > > Addressmap and the Memory Controller devices > > Does any kernel driv

Re: [PATCH 4/6] include linux pci_id-h add amd northbridge defines

2007-06-08 Thread Greg KH
On Fri, Jun 08, 2007 at 10:45:10AM -0600, [EMAIL PROTECTED] wrote: > From: Douglas Thompson <[EMAIL PROTECTED]> > > pci_ids.h needs two of the AMD NB device-ids namely, > Addressmap and the Memory Controller devices Does any kernel driver need this? We're trying to only include things in the pci