Re: [PATCH 4/6] mm: add a gup_fixup_start_addr hook

2019-05-29 Thread Catalin Marinas
Hi Christoph, On Sat, 25 May 2019 at 14:33, Christoph Hellwig wrote: > diff --git a/mm/gup.c b/mm/gup.c > index f173fcbaf1b2..1c21ecfbf38b 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -2117,6 +2117,10 @@ static void gup_pgd_range(unsigned long addr, unsigned > long end, > } while (pgdp+

Re: [PATCH 4/6] mm: add a gup_fixup_start_addr hook

2019-05-29 Thread Christoph Hellwig
On Tue, May 28, 2019 at 09:57:25AM -0600, Khalid Aziz wrote: > Since untagging addresses is a generic need required for far more than > gup, I prefer the way Andrey wrote it - > Linus, what do you think of picking up that trivial prep patch for 5.2?

Re: [PATCH 4/6] mm: add a gup_fixup_start_addr hook

2019-05-28 Thread Khalid Aziz
On 5/25/19 11:05 AM, Linus Torvalds wrote: > [ Adding Khalid, who added the sparc64 code ] > > On Sat, May 25, 2019 at 6:32 AM Christoph Hellwig wrote: >> >> This will allow sparc64 to override its ADI tags for >> get_user_pages and get_user_pages_fast. I have no idea why this >> is not required

Re: [PATCH 4/6] mm: add a gup_fixup_start_addr hook

2019-05-25 Thread Linus Torvalds
[ Adding Khalid, who added the sparc64 code ] On Sat, May 25, 2019 at 6:32 AM Christoph Hellwig wrote: > > This will allow sparc64 to override its ADI tags for > get_user_pages and get_user_pages_fast. I have no idea why this > is not required for plain old get_user_pages, but it keeps the > exi