Re: [PATCH 4/7] spi: spi-geni-qcom: Add support for GPI dma

2021-02-04 Thread Dmitry Baryshkov
On 11/01/2021 18:16, Vinod Koul wrote: We can use GPI DMA for devices where it is enabled by firmware. Add support for this mode Signed-off-by: Vinod Koul --- drivers/spi/spi-geni-qcom.c | 395 +++- 1 file changed, 384 insertions(+), 11 deletions(-) diff --gi

Re: [PATCH 4/7] spi: spi-geni-qcom: Add support for GPI dma

2021-01-12 Thread Vinod Koul
On 12-01-21, 16:01, Doug Anderson wrote: > Hi, > > On Mon, Jan 11, 2021 at 7:17 AM Vinod Koul wrote: > > > > We can use GPI DMA for devices where it is enabled by firmware. Add > > support for this mode > > > > Signed-off-by: Vinod Koul > > --- > > drivers/spi/spi-geni-qcom.c | 395

Re: [PATCH 4/7] spi: spi-geni-qcom: Add support for GPI dma

2021-01-12 Thread Doug Anderson
Hi, On Mon, Jan 11, 2021 at 7:17 AM Vinod Koul wrote: > > We can use GPI DMA for devices where it is enabled by firmware. Add > support for this mode > > Signed-off-by: Vinod Koul > --- > drivers/spi/spi-geni-qcom.c | 395 +++- > 1 file changed, 384 insertions(+)

Re: [PATCH 4/7] spi: spi-geni-qcom: Add support for GPI dma

2021-01-11 Thread Lukas Wunner
On Mon, Jan 11, 2021 at 08:46:48PM +0530, Vinod Koul wrote: > @@ -328,8 +609,34 @@ static int spi_geni_init(struct spi_geni_master *mas) > spi_tx_cfg &= ~CS_TOGGLE; > writel(spi_tx_cfg, se->base + SE_SPI_TRANS_CFG); > > + mas->tx = dma_request_slave_channel(mas->dev, "tx"); > +

Re: [PATCH 4/7] spi: spi-geni-qcom: Add support for GPI dma

2021-01-11 Thread Bjorn Andersson
On Mon 11 Jan 09:16 CST 2021, Vinod Koul wrote: > We can use GPI DMA for devices where it is enabled by firmware. Add > support for this mode > > Signed-off-by: Vinod Koul > --- > drivers/spi/spi-geni-qcom.c | 395 +++- > 1 file changed, 384 insertions(+), 11 del

Re: [PATCH 4/7] spi: spi-geni-qcom: Add support for GPI dma

2021-01-11 Thread Mark Brown
On Mon, Jan 11, 2021 at 08:46:48PM +0530, Vinod Koul wrote: > +static int get_xfer_mode(struct spi_master *spi) > +{ > + struct spi_geni_master *mas = spi_master_get_devdata(spi); > + struct geni_se *se = &mas->se; > + int mode = GENI_SE_FIFO; Why not use the core DMA mapping support?