Re: [PATCH 4/8] kvm: vmx: Set IBPB when running a different VCPU

2018-01-15 Thread Paolo Bonzini
On 13/01/2018 10:29, Woodhouse, David wrote: > On Fri, 2018-01-12 at 09:03 -0800, Jim Mattson wrote: >> The point behind the IPBP in vmx_vcpu_load is to prevent one VCPU from >> steering the speculative execution of the next. If the VMCS address is >> recycled, vmx_vcpu_load doesn't realize that th

Re: [PATCH 4/8] kvm: vmx: Set IBPB when running a different VCPU

2018-01-13 Thread Woodhouse, David
On Fri, 2018-01-12 at 09:03 -0800, Jim Mattson wrote: > The point behind the IPBP in vmx_vcpu_load is to prevent one VCPU from > steering the speculative execution of the next. If the VMCS address is > recycled, vmx_vcpu_load doesn't realize that the VCPUs are different, > and so it won't issue the

Re: [PATCH 4/8] kvm: vmx: Set IBPB when running a different VCPU

2018-01-12 Thread Jim Mattson
The point behind the IPBP in vmx_vcpu_load is to prevent one VCPU from steering the speculative execution of the next. If the VMCS address is recycled, vmx_vcpu_load doesn't realize that the VCPUs are different, and so it won't issue the IPBP. On Thu, Jan 11, 2018 at 5:49 PM, Wanpeng Li wrote: >

Re: [PATCH 4/8] kvm: vmx: Set IBPB when running a different VCPU

2018-01-11 Thread Wanpeng Li
2018-01-09 20:03 GMT+08:00 Paolo Bonzini : > > if (!already_loaded) { > @@ -4029,6 +4031,13 @@ static void free_loaded_vmcs(struct loaded_vmcs > *loaded_vmcs) > free_vmcs(loaded_vmcs->vmcs); > loaded_vmcs->vmcs = NULL; > WARN_ON(loaded_vmcs->shadow_vmcs != NULL); >