Re: [PATCH 4/9] arm: Split breakpoint validation into "check" and "commit"

2018-05-15 Thread Frederic Weisbecker
On Wed, May 09, 2018 at 12:32:57PM +0100, Mark Rutland wrote: > On Tue, May 08, 2018 at 12:13:23PM +0100, Mark Rutland wrote: > > Hi Frederick, > > > > On Sun, May 06, 2018 at 09:19:50PM +0200, Frederic Weisbecker wrote: > > > The breakpoint code mixes up attribute check and commit into a single >

Re: [PATCH 4/9] arm: Split breakpoint validation into "check" and "commit"

2018-05-10 Thread Frederic Weisbecker
On Wed, May 09, 2018 at 07:51:28PM +, Andy Lutomirski wrote: > On Wed, May 9, 2018 at 4:33 AM Mark Rutland wrote: > > > On Tue, May 08, 2018 at 12:13:23PM +0100, Mark Rutland wrote: > > > Hi Frederick, > > > > > > On Sun, May 06, 2018 at 09:19:50PM +0200, Frederic Weisbecker wrote: > > > > Th

Re: [PATCH 4/9] arm: Split breakpoint validation into "check" and "commit"

2018-05-09 Thread Andy Lutomirski
On Wed, May 9, 2018 at 4:33 AM Mark Rutland wrote: > On Tue, May 08, 2018 at 12:13:23PM +0100, Mark Rutland wrote: > > Hi Frederick, > > > > On Sun, May 06, 2018 at 09:19:50PM +0200, Frederic Weisbecker wrote: > > > The breakpoint code mixes up attribute check and commit into a single > > > code

Re: [PATCH 4/9] arm: Split breakpoint validation into "check" and "commit"

2018-05-09 Thread Mark Rutland
On Tue, May 08, 2018 at 12:13:23PM +0100, Mark Rutland wrote: > Hi Frederick, > > On Sun, May 06, 2018 at 09:19:50PM +0200, Frederic Weisbecker wrote: > > The breakpoint code mixes up attribute check and commit into a single > > code entity. Therefore the validation may return an error due to > >

Re: [PATCH 4/9] arm: Split breakpoint validation into "check" and "commit"

2018-05-08 Thread Mark Rutland
On Tue, May 08, 2018 at 12:13:23PM +0100, Mark Rutland wrote: > Hi Frederick, Argh, sorry for the typo -- I realise that K should not be there. Mark. > On Sun, May 06, 2018 at 09:19:50PM +0200, Frederic Weisbecker wrote: > > The breakpoint code mixes up attribute check and commit into a single >

Re: [PATCH 4/9] arm: Split breakpoint validation into "check" and "commit"

2018-05-08 Thread Mark Rutland
Hi Frederick, On Sun, May 06, 2018 at 09:19:50PM +0200, Frederic Weisbecker wrote: > The breakpoint code mixes up attribute check and commit into a single > code entity. Therefore the validation may return an error due to > incorrect atributes while still leaving halfway modified architecture > br