Re: [PATCH 4.9 46/92] x86/alternative: Print unadorned pointers

2018-02-13 Thread Greg Kroah-Hartman
On Sat, Feb 10, 2018 at 08:21:36PM +0100, Borislav Petkov wrote: > On Sat, Feb 10, 2018 at 11:14:18AM -0800, Kees Cook wrote: > > I would just revert this commit from kernels earlier than 4.15; this > > %p usage is in debugging, so %pK doesn't make much sense here. > > Yes, just drop it. That's on

Re: [PATCH 4.9 46/92] x86/alternative: Print unadorned pointers

2018-02-10 Thread Borislav Petkov
On Sat, Feb 10, 2018 at 11:14:18AM -0800, Kees Cook wrote: > I would just revert this commit from kernels earlier than 4.15; this > %p usage is in debugging, so %pK doesn't make much sense here. Yes, just drop it. That's only for debugging alternatives and not really needed in stable. -- Regards

Re: [PATCH 4.9 46/92] x86/alternative: Print unadorned pointers

2018-02-10 Thread Kees Cook
On Fri, Feb 9, 2018 at 11:23 PM, Greg Kroah-Hartman wrote: > On Fri, Feb 09, 2018 at 02:01:32PM -0800, Kees Cook wrote: >> On Fri, Feb 9, 2018 at 5:39 AM, Greg Kroah-Hartman >> wrote: >> > 4.9-stable review patch. If anyone has any objections, please let me know. >> > >> > -- >>

Re: [PATCH 4.9 46/92] x86/alternative: Print unadorned pointers

2018-02-09 Thread Greg Kroah-Hartman
On Fri, Feb 09, 2018 at 02:01:32PM -0800, Kees Cook wrote: > On Fri, Feb 9, 2018 at 5:39 AM, Greg Kroah-Hartman > wrote: > > 4.9-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Borislav Petkov > > > > (cherry picked from commit 0e6c

Re: [PATCH 4.9 46/92] x86/alternative: Print unadorned pointers

2018-02-09 Thread Kees Cook
On Fri, Feb 9, 2018 at 5:39 AM, Greg Kroah-Hartman wrote: > 4.9-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Borislav Petkov > > (cherry picked from commit 0e6c16c652cadaffd25a6bb326ec10da5bcec6b4) > > After commit ad67b74d2469 ("printk: