Re: [PATCH 44/74] lto: Mark functions used by the vsyscall init code visible

2012-09-01 Thread Andi Kleen
On Sat, Sep 01, 2012 at 07:16:45PM +0200, Andi Kleen wrote: > > I think that there should be a comment why the symbol needs to be > > visible (just copy the reasoning from the changelog). Otherwise someone > > might attempt to do a cleanup a few years later, noticing that there is > > no assembler

Re: [PATCH 44/74] lto: Mark functions used by the vsyscall init code visible

2012-09-01 Thread Andi Kleen
> I think that there should be a comment why the symbol needs to be > visible (just copy the reasoning from the changelog). Otherwise someone > might attempt to do a cleanup a few years later, noticing that there is > no assembler code calling get_random_int(). Ok. On hindsight maybe it's better t

Re: [PATCH 44/74] lto: Mark functions used by the vsyscall init code visible

2012-09-01 Thread Michal Marek
Dne 19.8.2012 04:56, Andi Kleen napsal(a): > From: Andi Kleen > > The vsyscall code is compiled without LTO. This also includes > its init function. The function which are called by it have > to be visible, otherwise they could be optimized away > > Signed-off-by: Andi Kleen > --- > drivers/ch