Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks

2017-06-12 Thread Nicolas Ferre
Le 12/06/2017 à 15:25, Daniel Lezcano a écrit : > On 12/06/2017 14:54, Nicolas Ferre wrote: > > [ ... ] > >>> I like the 'chosen' approach with the nodes you are proposing below. Thanks >>> for >>> the constructive suggestion. The binding description matches perfectly what >>> we >>> are trying

Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks

2017-06-12 Thread Daniel Lezcano
On 12/06/2017 14:54, Nicolas Ferre wrote: [ ... ] >> I like the 'chosen' approach with the nodes you are proposing below. Thanks >> for >> the constructive suggestion. The binding description matches perfectly what >> we >> are trying to achieve. >> >> Rob? what do you think? > > I'm following

Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks

2017-06-12 Thread Nicolas Ferre
Le 08/06/2017 à 10:40, Daniel Lezcano a écrit : > On Thu, Jun 08, 2017 at 10:13:34AM +0200, Boris Brezillon wrote: >> On Thu, 8 Jun 2017 09:44:46 +0200 >> Daniel Lezcano wrote: >> >>> +Mark Rutland, +Rob Herring >> >> Mark doesn't seem to be CCed. > > Ah, yes. Thanks for fixing this. > >>> >>> >

Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks

2017-06-08 Thread Boris Brezillon
On Thu, 8 Jun 2017 10:40:26 +0200 Daniel Lezcano wrote: > > > > > > Alexandre, Boris, have a look at > > > https://www.spinics.net/lists/arm-kernel/msg572652.html > > > > > > That will tell you the story. > > > > Then we're in a deadlock situation here. I'm tired of hearing this kind > > of

Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks

2017-06-08 Thread Alexandre Belloni
On 08/06/2017 at 10:24:17 +0200, Daniel Lezcano wrote: > On Thu, Jun 08, 2017 at 09:59:01AM +0200, Alexandre Belloni wrote: > > On 08/06/2017 at 09:44:46 +0200, Daniel Lezcano wrote: > > > > > > +Mark Rutland, +Rob Herring > > > > > > > > > Alexandre, Boris, have a look at > > > https://www.spi

Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks

2017-06-08 Thread Daniel Lezcano
On Thu, Jun 08, 2017 at 10:13:34AM +0200, Boris Brezillon wrote: > On Thu, 8 Jun 2017 09:44:46 +0200 > Daniel Lezcano wrote: > > > +Mark Rutland, +Rob Herring > > Mark doesn't seem to be CCed. Ah, yes. Thanks for fixing this. > > > > > > Alexandre, Boris, have a look at > > https://www.spin

Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks

2017-06-08 Thread Boris Brezillon
On Thu, 8 Jun 2017 10:24:17 +0200 Daniel Lezcano wrote: > On Thu, Jun 08, 2017 at 09:59:01AM +0200, Alexandre Belloni wrote: > > On 08/06/2017 at 09:44:46 +0200, Daniel Lezcano wrote: > > > > > > +Mark Rutland, +Rob Herring > > > > > > > > > Alexandre, Boris, have a look at > > > https://ww

Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks

2017-06-08 Thread Daniel Lezcano
On Thu, Jun 08, 2017 at 09:59:01AM +0200, Alexandre Belloni wrote: > On 08/06/2017 at 09:44:46 +0200, Daniel Lezcano wrote: > > > > +Mark Rutland, +Rob Herring > > > > > > Alexandre, Boris, have a look at > > https://www.spinics.net/lists/arm-kernel/msg572652.html > > > > That will tell you th

Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks

2017-06-08 Thread Boris Brezillon
On Thu, 8 Jun 2017 09:44:46 +0200 Daniel Lezcano wrote: > +Mark Rutland, +Rob Herring Mark doesn't seem to be CCed. > > > Alexandre, Boris, have a look at > https://www.spinics.net/lists/arm-kernel/msg572652.html > > That will tell you the story. Then we're in a deadlock situation here. I'

Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks

2017-06-08 Thread Alexandre Belloni
On 08/06/2017 at 09:44:46 +0200, Daniel Lezcano wrote: > > +Mark Rutland, +Rob Herring > > > Alexandre, Boris, have a look at > https://www.spinics.net/lists/arm-kernel/msg572652.html > > That will tell you the story. > Ok, so is the solution putting the driver back in mach-at91 were we can

Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks

2017-06-08 Thread Daniel Lezcano
+Mark Rutland, +Rob Herring Alexandre, Boris, have a look at https://www.spinics.net/lists/arm-kernel/msg572652.html That will tell you the story. On Thu, Jun 08, 2017 at 07:42:36AM +0200, Boris Brezillon wrote: > Le Thu, 8 Jun 2017 01:17:15 +0200, > Alexandre Belloni a écrit : > > > On 07/

Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks

2017-06-07 Thread Boris Brezillon
Le Wed, 7 Jun 2017 23:38:10 +0200, Daniel Lezcano a écrit : > On Wed, Jun 07, 2017 at 05:09:08PM +0200, Alexandre Belloni wrote: > > On 07/06/2017 at 16:17:35 +0200, Daniel Lezcano wrote: > > > > > > This driver uses regmap and syscon to be able to probe early in the > > > > > > boot > > > > >

Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks

2017-06-07 Thread Boris Brezillon
Le Wed, 7 Jun 2017 23:08:48 +0200, Daniel Lezcano a écrit : > On Wed, Jun 07, 2017 at 05:27:50PM +0200, Alexandre Belloni wrote: > > On 07/06/2017 at 16:17:35 +0200, Daniel Lezcano wrote: > > > > You mean you don't like how it is used? Or you don't think having the > > > > timer full name is us

Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks

2017-06-07 Thread Boris Brezillon
Le Thu, 8 Jun 2017 01:17:15 +0200, Alexandre Belloni a écrit : > On 07/06/2017 at 23:08:48 +0200, Daniel Lezcano wrote: > > > I was going to agree but this is not flexible enough because the > > > quadrature decoder always uses the first two channels. So on some > > > products, we may have: > > >

Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks

2017-06-07 Thread Alexandre Belloni
On 07/06/2017 at 23:08:48 +0200, Daniel Lezcano wrote: > > I was going to agree but this is not flexible enough because the > > quadrature decoder always uses the first two channels. So on some > > products, we may have: > > - TCB0: > >o channels 0,1: qdec > >o channel 2: clocksource > >

Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks

2017-06-07 Thread Alexandre Belloni
On 07/06/2017 at 23:38:10 +0200, Daniel Lezcano wrote: > On Wed, Jun 07, 2017 at 05:09:08PM +0200, Alexandre Belloni wrote: > I suggest to look what is in 'lot-of-things()' and especially what is doing > regcache_read(). > I know it does a lot... > May be you can reconsider the regmap? This driv

Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks

2017-06-07 Thread Daniel Lezcano
On Wed, Jun 07, 2017 at 05:09:08PM +0200, Alexandre Belloni wrote: > On 07/06/2017 at 16:17:35 +0200, Daniel Lezcano wrote: > > > > > This driver uses regmap and syscon to be able to probe early in the > > > > > boot > > > > > and avoid having to switch on the TCB clocksource later. Using regmap

Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks

2017-06-07 Thread Daniel Lezcano
On Wed, Jun 07, 2017 at 05:27:50PM +0200, Alexandre Belloni wrote: > On 07/06/2017 at 16:17:35 +0200, Daniel Lezcano wrote: > > > You mean you don't like how it is used? Or you don't think having the > > > timer full name is useful? > > > > The field is not needed, the only place where it is used

Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks

2017-06-07 Thread Alexandre Belloni
On 07/06/2017 at 16:17:35 +0200, Daniel Lezcano wrote: > > You mean you don't like how it is used? Or you don't think having the > > timer full name is useful? > > The field is not needed, the only place where it is used is where we affect > it. > It is used in tcb_clksrc_register: tc.clksrc.

Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks

2017-06-07 Thread Alexandre Belloni
On 07/06/2017 at 16:17:35 +0200, Daniel Lezcano wrote: > > > > This driver uses regmap and syscon to be able to probe early in the boot > > > > and avoid having to switch on the TCB clocksource later. Using regmap > > > > also > > > > means that unused TCB channels may be used by other drivers (PW

Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks

2017-06-07 Thread Daniel Lezcano
On Tue, Jun 06, 2017 at 08:05:59PM +0200, Alexandre Belloni wrote: > On 06/06/2017 at 17:21:05 +0200, Daniel Lezcano wrote: > > On Tue, May 30, 2017 at 11:51:27PM +0200, Alexandre Belloni wrote: > > > Add a driver for the Atmel Timer Counter Blocks. This driver provides a > > > clocksource and a cl

Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks

2017-06-06 Thread Alexandre Belloni
On 06/06/2017 at 17:21:05 +0200, Daniel Lezcano wrote: > On Tue, May 30, 2017 at 11:51:27PM +0200, Alexandre Belloni wrote: > > Add a driver for the Atmel Timer Counter Blocks. This driver provides a > > clocksource and a clockevent device. The clockevent device is linked to the > > clocksource cou

Re: [PATCH 46/58] clocksource/drivers: Add a new driver for the Atmel ARM TC blocks

2017-06-06 Thread Daniel Lezcano
On Tue, May 30, 2017 at 11:51:27PM +0200, Alexandre Belloni wrote: > Add a driver for the Atmel Timer Counter Blocks. This driver provides a > clocksource and a clockevent device. The clockevent device is linked to the > clocksource counter and so it will run at the same frequency. Where is the cl