Re: [PATCH 5/5] arm/arm64: smccc: Add ARCH_SOC_ID support

2020-05-01 Thread John Garry
On 01/05/2020 17:05, Sudeep Holla wrote: On Fri, May 01, 2020 at 04:25:27PM +0100, John Garry wrote: On 30/04/2020 12:48, Sudeep Holla wrote: +static int __init smccc_soc_init(void) +{ + struct device *dev; + int ret, soc_id_rev; + struct arm_smccc_res res; + static char

Re: [PATCH 5/5] arm/arm64: smccc: Add ARCH_SOC_ID support

2020-05-01 Thread Sudeep Holla
On Fri, May 01, 2020 at 04:25:27PM +0100, John Garry wrote: > On 30/04/2020 12:48, Sudeep Holla wrote: > > +static int __init smccc_soc_init(void) > > +{ > > + struct device *dev; > > + int ret, soc_id_rev; > > + struct arm_smccc_res res; > > + static char soc_id_str[8], soc_id_rev_str[12];

Re: [PATCH 5/5] arm/arm64: smccc: Add ARCH_SOC_ID support

2020-05-01 Thread Sudeep Holla
Hi Steve, Thanks for taking a reviewing these patches. On Fri, May 01, 2020 at 04:07:39PM +0100, Steven Price wrote: > On 30/04/2020 12:48, Sudeep Holla wrote: > > SMCCC v1.2 adds a new optional function SMCCC_ARCH_SOC_ID to obtain a > > SiP defined SoC identification value. Add support for the s

Re: [PATCH 5/5] arm/arm64: smccc: Add ARCH_SOC_ID support

2020-05-01 Thread John Garry
On 30/04/2020 12:48, Sudeep Holla wrote: +static int __init smccc_soc_init(void) +{ + struct device *dev; + int ret, soc_id_rev; + struct arm_smccc_res res; + static char soc_id_str[8], soc_id_rev_str[12]; + + if (arm_smccc_get_version() < ARM_SMCCC_VERSION_1_2) +

Re: [PATCH 5/5] arm/arm64: smccc: Add ARCH_SOC_ID support

2020-05-01 Thread Steven Price
On 30/04/2020 12:48, Sudeep Holla wrote: SMCCC v1.2 adds a new optional function SMCCC_ARCH_SOC_ID to obtain a SiP defined SoC identification value. Add support for the same. Also using the SoC bus infrastructure, let us expose the platform specific SoC atrributes under sysfs. We also provide cu