Re: [PATCH 5/5] efi: Capsule update support and pstore backend

2013-10-17 Thread Andi Kleen
> > I'm a little uneasy having this run by default if enabled, even if it's > > disabled by default in the config. > > What would be the canonical way to enable this feature then? Have a file White list systems and a option to force enable. -Andi -- To unsubscribe from this list: send the line

Re: [PATCH 5/5] efi: Capsule update support and pstore backend

2013-10-17 Thread Andi Kleen
> But, as Eric said, it should be OK if it is implemented in the kdump kenel. kdump doesn't work for a lot of use cases (too much memory consumption) -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordo

Re: [PATCH 5/5] efi: Capsule update support and pstore backend

2013-10-17 Thread Matt Fleming
On Wed, 16 Oct, at 01:14:16PM, Andi Kleen wrote: > > + It should be noted that enabling this opton will pass a capsule > > + to the firmware on every boot. Some firmware will not allow a > > + user to enter the BIOS setup when a capsule has been registered > > + on the previous boot

Re: [PATCH 5/5] efi: Capsule update support and pstore backend

2013-10-17 Thread Matt Fleming
On Wed, 16 Oct, at 02:52:25PM, Luck, Tony wrote: > > Where by "May not function correctly" you mean "May crash the system"? > > I'm a little uneasy having this run by default if enabled, even if it's > > disabled by default in the config. > > There's also an "either/or" choice between using efi-

Re: [PATCH 5/5] efi: Capsule update support and pstore backend

2013-10-17 Thread Matt Fleming
On Wed, 16 Oct, at 03:19:39PM, Matthew Garrett wrote: > On Wed, Oct 16, 2013 at 02:51:00PM +0100, Matt Fleming wrote: > > > + Many EFI machines have buggy implementations of the UpdateCapsule() > > + runtime service. This option will enable code that may not function > > + correctly wi

RE: [PATCH 5/5] efi: Capsule update support and pstore backend

2013-10-16 Thread Seiji Aguchi
> There's also an "either/or" choice between using efi-capsule with pstore, and > the > traditional kexec/kdump method for getting a memory dump from a crash. We > have to go through a reset to save the capsule - but we don't want a reset for > kexec. Perhaps we can pass the reset parameters th

Re: [PATCH 5/5] efi: Capsule update support and pstore backend

2013-10-16 Thread Andi Kleen
> + It should be noted that enabling this opton will pass a capsule > + to the firmware on every boot. Some firmware will not allow a > + user to enter the BIOS setup when a capsule has been registered > + on the previous boot. That sounds like a problem. Can this be fixed

RE: [PATCH 5/5] efi: Capsule update support and pstore backend

2013-10-16 Thread Luck, Tony
> Where by "May not function correctly" you mean "May crash the system"? > I'm a little uneasy having this run by default if enabled, even if it's > disabled by default in the config. There's also an "either/or" choice between using efi-capsule with pstore, and the traditional kexec/kdump metho

Re: [PATCH 5/5] efi: Capsule update support and pstore backend

2013-10-16 Thread Matthew Garrett
On Wed, Oct 16, 2013 at 02:51:00PM +0100, Matt Fleming wrote: > + Many EFI machines have buggy implementations of the UpdateCapsule() > + runtime service. This option will enable code that may not function > + correctly with your firmware. Where by "May not function correctly" y