Re: [PATCH 5/5] gpio: move gpio_ensure_requested() into legacy C file

2014-07-23 Thread Linus Walleij
On Tue, Jul 22, 2014 at 9:17 AM, Alexandre Courbot wrote: > gpio_ensure_requested() only makes sense when using the integer-based > GPIO API, so make sure it is called from there instead of the gpiod > API which we know cannot be called with a non-requested GPIO anyway. > > The uses of gpio_ensur

Re: [PATCH 5/5] gpio: move gpio_ensure_requested() into legacy C file

2014-07-22 Thread Varka Bhadram
On 07/22/2014 12:47 PM, Alexandre Courbot wrote: (...) + if (WARN(test_and_set_bit(FLAG_REQUESTED, &desc->flags) == 0, + "autorequest GPIO-%d\n", desc_to_gpio(desc))) { + if (!try_module_get(chip->owner)) { + gpiod_err(desc, "%s: m