Re: [PATCH 5/5] lockdep: pack subclass/trylock/read/check into a single argument

2014-01-21 Thread Oleg Nesterov
On 01/21, Steven Rostedt wrote: > > On Tue, 21 Jan 2014 19:43:10 +0100 > Oleg Nesterov wrote: > > > Do you mean __attribute__((packed)) ? > > I think Dave means: > > unsigned char subclass : 3; > unsigned char trylock : 1; > unsigned char read : 2; > unsigned char c

Re: [PATCH 5/5] lockdep: pack subclass/trylock/read/check into a single argument

2014-01-21 Thread Steven Rostedt
On Tue, 21 Jan 2014 19:43:10 +0100 Oleg Nesterov wrote: > On 01/21, Dave Jones wrote: > > > > On Tue, Jan 21, 2014 at 03:10:22PM +0100, Peter Zijlstra wrote: > > > > > > I tried the below but filed to see my vmlinux shrink, maybe I'm just not > > > building the right kernel, or otherwise GCC i

Re: [PATCH 5/5] lockdep: pack subclass/trylock/read/check into a single argument

2014-01-21 Thread Oleg Nesterov
On 01/21, Dave Jones wrote: > > On Tue, Jan 21, 2014 at 03:10:22PM +0100, Peter Zijlstra wrote: > > > > I tried the below but filed to see my vmlinux shrink, maybe I'm just not > > building the right kernel, or otherwise GCC is stupid. > > > > -extern void lock_acquire(struct lockdep_map *lock

Re: [PATCH 5/5] lockdep: pack subclass/trylock/read/check into a single argument

2014-01-21 Thread Dave Jones
On Tue, Jan 21, 2014 at 03:10:22PM +0100, Peter Zijlstra wrote: > > I tried the below but filed to see my vmlinux shrink, maybe I'm just not > building the right kernel, or otherwise GCC is stupid. > > -extern void lock_acquire(struct lockdep_map *lock, unsigned int subclass, > -

Re: [PATCH 5/5] lockdep: pack subclass/trylock/read/check into a single argument

2014-01-21 Thread Oleg Nesterov
On 01/21, Peter Zijlstra wrote: > > I tried the below but filed to see my vmlinux shrink, maybe I'm just not > building the right kernel, or otherwise GCC is stupid. ... > +struct lockdep_acquire_flags { > + unsigned long subclass : 3; > + unsigned long trylock : 1; > + unsigned long

Re: [PATCH 5/5] lockdep: pack subclass/trylock/read/check into a single argument

2014-01-21 Thread Peter Zijlstra
I tried the below but filed to see my vmlinux shrink, maybe I'm just not building the right kernel, or otherwise GCC is stupid. --- include/linux/lockdep.h | 33 ++--- kernel/locking/lockdep.c | 11 +++ 2 files changed, 32 insertions(+), 7 deletions(-) -