Re: [PATCH 5/5] thunderbolt: Add support for runtime PM

2018-07-08 Thread Mika Westerberg
On Mon, Jul 09, 2018 at 04:20:00AM +, mario.limoncie...@dell.com wrote: > In practice I don't anticipate anyone in the industry outside of Apple wiring > up TBT > with RTD3 unless it's at least Alpine Ridge or newer. I don't think Apple does it even with Alpine Ridge. I have one Macbook here

RE: [PATCH 5/5] thunderbolt: Add support for runtime PM

2018-07-08 Thread Mario.Limonciello
; Subject: Re: [PATCH 5/5] thunderbolt: Add support for runtime PM > > On Sun, Jul 8, 2018 at 10:31 AM Mika Westerberg > wrote: > > > > On Sat, Jul 07, 2018 at 11:14:01PM +0200, Lukas Wunner wrote: > > > > > > Because I'm fairly certain that > > &g

Re: [PATCH 5/5] thunderbolt: Add support for runtime PM

2018-07-08 Thread Yehezkel Bernat
On Sun, Jul 8, 2018 at 10:31 AM Mika Westerberg wrote: > > On Sat, Jul 07, 2018 at 11:14:01PM +0200, Lukas Wunner wrote: > > > > Because I'm fairly certain that > > I do not get a PME for the Light Ridge in my MacBook Pro, but I'll test > > this once more and modify negotiate_os_control() to grant

Re: [PATCH 5/5] thunderbolt: Add support for runtime PM

2018-07-08 Thread Mika Westerberg
On Sat, Jul 07, 2018 at 11:14:01PM +0200, Lukas Wunner wrote: > On Mon, Jun 18, 2018 at 02:07:31PM +0300, Mika Westerberg wrote: > > Implement this using standard Linux runtime PM APIs so that when all the > > children devices are runtime suspended, the Thunderbolt host controller > > PCI device is

Re: [PATCH 5/5] thunderbolt: Add support for runtime PM

2018-07-07 Thread Lukas Wunner
On Mon, Jun 18, 2018 at 02:07:31PM +0300, Mika Westerberg wrote: > Implement this using standard Linux runtime PM APIs so that when all the > children devices are runtime suspended, the Thunderbolt host controller > PCI device is runtime suspended as well. The ICM firmware then starts > powering do

Re: [PATCH 5/5] thunderbolt: Add support for runtime PM

2018-07-07 Thread Mika Westerberg
On Sat, Jul 07, 2018 at 04:43:48PM +0200, Lukas Wunner wrote: > On Sat, Jul 07, 2018 at 05:25:53PM +0300, Mika Westerberg wrote: > > On Sat, Jul 07, 2018 at 03:38:15PM +0200, Lukas Wunner wrote: > > > You're setting pm_runtime_no_callbacks() on the domain. A side effect of > > > setting this flag

Re: [PATCH 5/5] thunderbolt: Add support for runtime PM

2018-07-07 Thread Lukas Wunner
On Sat, Jul 07, 2018 at 05:25:53PM +0300, Mika Westerberg wrote: > On Sat, Jul 07, 2018 at 03:38:15PM +0200, Lukas Wunner wrote: > > You're setting pm_runtime_no_callbacks() on the domain. A side effect of > > setting this flag is that whenever the domain's device is runtime resumed, > > it's pare

Re: [PATCH 5/5] thunderbolt: Add support for runtime PM

2018-07-07 Thread Mika Westerberg
On Sat, Jul 07, 2018 at 03:38:15PM +0200, Lukas Wunner wrote: > On Mon, Jun 18, 2018 at 02:07:31PM +0300, Mika Westerberg wrote: > > --- a/drivers/thunderbolt/domain.c > > +++ b/drivers/thunderbolt/domain.c > > @@ -132,6 +133,8 @@ static ssize_t boot_acl_show(struct device *dev, struct > > device_

Re: [PATCH 5/5] thunderbolt: Add support for runtime PM

2018-07-07 Thread Lukas Wunner
On Mon, Jun 18, 2018 at 02:07:31PM +0300, Mika Westerberg wrote: > --- a/drivers/thunderbolt/domain.c > +++ b/drivers/thunderbolt/domain.c > @@ -132,6 +133,8 @@ static ssize_t boot_acl_show(struct device *dev, struct > device_attribute *attr, > if (!uuids) > return -ENOMEM; >