Re: [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups()

2019-08-04 Thread Tudor.Ambarus
On 08/01/2019 09:42 AM, Boris Brezillon wrote: > Almost all of this (except the s3an specific bits) should be done in > the previous patch. So I'll put a condition on the R-b I placed on patch > 4: some of this code should be moved there. You're right, will do. Cheers, ta

Re: [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups()

2019-07-31 Thread Boris Brezillon
On Wed, 31 Jul 2019 09:12:16 + wrote: > From: Tudor Ambarus > > s3an_nor_scan() was overriding the opcode selection done in > spi_nor_default_setup(). Set nor->setup() method in order to > avoid unnecessary call to spi_nor_default_setup(). > > Signed-off-by: Tudor Ambarus > --- > drivers

RE: [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups()

2019-07-31 Thread Naga Sureshkumar Relli
.kernel.org; > linux-...@lists.infradead.org; > miquel.ray...@bootlin.com; computersforpe...@gmail.com; dw...@infradead.org > Subject: Re: [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups() > > Hi, Naga, > > On 07/31/2019 03:31 PM, Naga Sureshkumar Relli wrot

RE: [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups()

2019-07-31 Thread Naga Sureshkumar Relli
.org; > miquel.ray...@bootlin.com; computersforpe...@gmail.com; dw...@infradead.org > Subject: Re: [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups() > > On Wed, 31 Jul 2019 12:31:19 + > Naga Sureshkumar Relli wrote: > > > Hi Tudor, > > > > Thanks for the

Re: [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups()

2019-07-31 Thread Tudor.Ambarus
Hi, Naga, On 07/31/2019 03:31 PM, Naga Sureshkumar Relli wrote: >> +if (nor->info->flags & SPI_S3AN) >> +s3an_post_sfdp_fixups(nor); >> } >> > Instead of checking the flags, why can't we call directly the nor_fixups? > like Boris implementation nor->info->fixups->post_sfdp() > htt

Re: [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups()

2019-07-31 Thread Boris Brezillon
On Wed, 31 Jul 2019 12:31:19 + Naga Sureshkumar Relli wrote: > Hi Tudor, > > Thanks for the updates. With these kind of updates, we can add Vendor specific > Code easily, like Xilinx Dual parallel and stacked modes. > In these configurations we need to tweak the nor parameters like page_size

RE: [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups()

2019-07-31 Thread Naga Sureshkumar Relli
Hi Tudor, Thanks for the updates. With these kind of updates, we can add Vendor specific Code easily, like Xilinx Dual parallel and stacked modes. In these configurations we need to tweak the nor parameters like page_size, sectors etc. So with the help of these patches. we can easily update these