RE: [PATCH 5/6] net: macb: add support for high speed interface

> >> switch (state->interface) { >> +case PHY_INTERFACE_MODE_NA: > >I would not list PHY_INTERFACE_MODE_NA here. > This was to experiment in band mode with sfp. phylink_sfp_module_insert call phylink_validate with interface set to PHY_INTERFACE_MODE_NA , if it is not listed in validate m

Re: [PATCH 5/6] net: macb: add support for high speed interface

> switch (state->interface) { > + case PHY_INTERFACE_MODE_NA: I would not list PHY_INTERFACE_MODE_NA here. > + case PHY_INTERFACE_MODE_USXGMII: > + case PHY_INTERFACE_MODE_10GKR: > + if (bp->caps & MACB_CAPS_GIGABIT_MODE_AVAILABLE) { > + phylink_s