Re: [PATCH 5/6] x86/ptrace: down with test_thread_flag(TIF_IA32)

2016-06-14 Thread Dmitry Safonov
On 06/14/2016 05:34 PM, Oleg Nesterov wrote: Well, perhaps we should also remove SA_IA32_ABI|SA_X32_ABI from oact->sa.sa_flags in do_sigaction() to ensure that these non-uapi flags won't leak to user-space, but probably we do not really care. Thanks, I missed that - will mask it out to v2.

Re: [PATCH 5/6] x86/ptrace: down with test_thread_flag(TIF_IA32)

2016-06-14 Thread Oleg Nesterov
On 06/13, Andy Lutomirski wrote: > > On Mon, Jun 13, 2016 at 6:50 AM, Oleg Nesterov wrote: > > > > Well, I can't resist but to me SA_IA32_ABI/SA_X32_ABI looks like a hack > > too. We actually shift TIF_*32 into k_sigaction->flags, and the fact > > that we do this per-signal looks, well, interesti

Re: [PATCH 5/6] x86/ptrace: down with test_thread_flag(TIF_IA32)

2016-06-13 Thread Andy Lutomirski
On Mon, Jun 13, 2016 at 6:50 AM, Oleg Nesterov wrote: > To avoid the confusion, let me first say that I am not going to argue > with these changes, I simply do not understand the problem space enough. > > On 06/10, Andy Lutomirski wrote: >> >> On Fri, Jun 10, 2016 at 1:07 PM, Oleg Nesterov wrote:

Re: [PATCH 5/6] x86/ptrace: down with test_thread_flag(TIF_IA32)

2016-06-13 Thread Oleg Nesterov
To avoid the confusion, let me first say that I am not going to argue with these changes, I simply do not understand the problem space enough. On 06/10, Andy Lutomirski wrote: > > On Fri, Jun 10, 2016 at 1:07 PM, Oleg Nesterov wrote: > > > > IIRC, CRIU can't c/r the 32-bit applications, or this i

Re: [PATCH 5/6] x86/ptrace: down with test_thread_flag(TIF_IA32)

2016-06-10 Thread Andy Lutomirski
On Fri, Jun 10, 2016 at 1:07 PM, Oleg Nesterov wrote: > On 06/09, Andy Lutomirski wrote: >> >> On Jun 6, 2016 3:21 PM, "Oleg Nesterov" wrote: >> > >> > On 06/01, Dmitry Safonov wrote: >> > > >> > > Note, that this will work only if application has changed it's CS. >> > >> > So, suppose it changes

Re: [PATCH 5/6] x86/ptrace: down with test_thread_flag(TIF_IA32)

2016-06-10 Thread Oleg Nesterov
On 06/09, Andy Lutomirski wrote: > > On Jun 6, 2016 3:21 PM, "Oleg Nesterov" wrote: > > > > On 06/01, Dmitry Safonov wrote: > > > > > > Note, that this will work only if application has changed it's CS. > > > > So, suppose it changes it's CS and crashes, > > > > > If the application does 32-bit sy

Re: [PATCH 5/6] x86/ptrace: down with test_thread_flag(TIF_IA32)

2016-06-09 Thread Andy Lutomirski
On Jun 6, 2016 3:21 PM, "Oleg Nesterov" wrote: > > On 06/01, Dmitry Safonov wrote: > > > > Note, that this will work only if application has changed it's CS. > > So, suppose it changes it's CS and crashes, > > > If the application does 32-bit syscall with __USER_CS, ptrace > > @@ -1355,7 +1355,7 @

Re: [PATCH 5/6] x86/ptrace: down with test_thread_flag(TIF_IA32)

2016-06-07 Thread Dmitry Safonov
On 06/07/2016 12:19 AM, Oleg Nesterov wrote: On 06/01, Dmitry Safonov wrote: Note, that this will work only if application has changed it's CS. So, suppose it changes it's CS and crashes, If the application does 32-bit syscall with __USER_CS, ptrace @@ -1355,7 +1355,7 @@ void update_regset_

Re: [PATCH 5/6] x86/ptrace: down with test_thread_flag(TIF_IA32)

2016-06-06 Thread Oleg Nesterov
On 06/01, Dmitry Safonov wrote: > > Note, that this will work only if application has changed it's CS. So, suppose it changes it's CS and crashes, > If the application does 32-bit syscall with __USER_CS, ptrace > @@ -1355,7 +1355,7 @@ void update_regset_xstate_info(unsigned int size, u64 > xstat

Re: [PATCH 5/6] x86/ptrace: down with test_thread_flag(TIF_IA32)

2016-06-03 Thread Cyrill Gorcunov
On Fri, Jun 03, 2016 at 01:27:33PM +0300, Dmitry Safonov wrote: > > > > Looks reasonable! Still if cs has been changed to non-compat > > selector and we now return 64bit registers set, won't it > > cause problems for old tools? I suspect it should not but > > still. > > > > Thanks! Hmm, strace w

Re: [PATCH 5/6] x86/ptrace: down with test_thread_flag(TIF_IA32)

2016-06-03 Thread Dmitry Safonov
On 06/03/2016 12:57 PM, Cyrill Gorcunov wrote: On Wed, Jun 01, 2016 at 04:11:36PM +0300, Dmitry Safonov wrote: As the task isn't executing at the moment of {GET,SET}REGS, return regset that corresponds to code selector, rather than value of TIF_IA32 flag. I.e. if we ptrace i386 elf binary that h

Re: [PATCH 5/6] x86/ptrace: down with test_thread_flag(TIF_IA32)

2016-06-03 Thread Cyrill Gorcunov
On Wed, Jun 01, 2016 at 04:11:36PM +0300, Dmitry Safonov wrote: > As the task isn't executing at the moment of {GET,SET}REGS, > return regset that corresponds to code selector, rather than > value of TIF_IA32 flag. > I.e. if we ptrace i386 elf binary that has just changed it's > code selector to __