Re: [PATCH 5/6] xfrm_user: ensure user supplied esn replay window is valid

2012-09-20 Thread Mathias Krause
On Thu, Sep 20, 2012 at 9:05 AM, Steffen Klassert wrote: > On Thu, Sep 20, 2012 at 08:12:11AM +0200, Mathias Krause wrote: >> On Thu, Sep 20, 2012 at 12:38 AM, Ben Hutchings >> wrote: >> > On Wed, 2012-09-19 at 23:33 +0200, Mathias Krause wrote: >> >> > I'm a little worried that the user-provided

Re: [PATCH 5/6] xfrm_user: ensure user supplied esn replay window is valid

2012-09-20 Thread Mathias Krause
On Thu, Sep 20, 2012 at 8:12 AM, Mathias Krause wrote: > What still might happen is the overflow in xfrm_replay_state_esn_len() > resulting in a to small bitmap allocation for the requested replay > size. But that gets catched in xfrm_init_replay(). Little late, but > hey. Sorry, I mixed that up.

Re: [PATCH 5/6] xfrm_user: ensure user supplied esn replay window is valid

2012-09-20 Thread Steffen Klassert
On Thu, Sep 20, 2012 at 08:12:11AM +0200, Mathias Krause wrote: > On Thu, Sep 20, 2012 at 12:38 AM, Ben Hutchings > wrote: > > On Wed, 2012-09-19 at 23:33 +0200, Mathias Krause wrote: > > > I'm a little worried that the user-provided > > xfrm_replay_state_esn::bmp_len is not being directly valida

Re: [PATCH 5/6] xfrm_user: ensure user supplied esn replay window is valid

2012-09-19 Thread Mathias Krause
On Thu, Sep 20, 2012 at 12:38 AM, Ben Hutchings wrote: > On Wed, 2012-09-19 at 23:33 +0200, Mathias Krause wrote: >> The current code fails to ensure that the netlink message actually >> contains as many bytes as the header indicates. If a user creates a new >> state or updates an existing one but

Re: [PATCH 5/6] xfrm_user: ensure user supplied esn replay window is valid

2012-09-19 Thread Ben Hutchings
On Wed, 2012-09-19 at 23:33 +0200, Mathias Krause wrote: > The current code fails to ensure that the netlink message actually > contains as many bytes as the header indicates. If a user creates a new > state or updates an existing one but does not supply the bytes for the > whole ESN replay window,