Re: [PATCH 5/9] mm: compaction: Acquire the zone->lru_lock as late as possible

2012-09-26 Thread Mel Gorman
On Tue, Sep 25, 2012 at 02:39:31PM -0700, Andrew Morton wrote: > On Tue, 25 Sep 2012 17:13:27 +0900 > Minchan Kim wrote: > > > I see. To me, your saying is better than current comment. > > I hope comment could be more explicit. > > > > diff --git a/mm/compaction.c b/mm/compaction.c > > index df0

Re: [PATCH 5/9] mm: compaction: Acquire the zone->lru_lock as late as possible

2012-09-25 Thread Minchan Kim
On Tue, Sep 25, 2012 at 02:39:31PM -0700, Andrew Morton wrote: > On Tue, 25 Sep 2012 17:13:27 +0900 > Minchan Kim wrote: > > > I see. To me, your saying is better than current comment. > > I hope comment could be more explicit. > > > > diff --git a/mm/compaction.c b/mm/compaction.c > > index df0

Re: [PATCH 5/9] mm: compaction: Acquire the zone->lru_lock as late as possible

2012-09-25 Thread Andrew Morton
On Tue, 25 Sep 2012 17:13:27 +0900 Minchan Kim wrote: > I see. To me, your saying is better than current comment. > I hope comment could be more explicit. > > diff --git a/mm/compaction.c b/mm/compaction.c > index df01b4e..f1d2cc7 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -542,

Re: [PATCH 5/9] mm: compaction: Acquire the zone->lru_lock as late as possible

2012-09-25 Thread Minchan Kim
On Tue, Sep 25, 2012 at 08:51:05AM +0100, Mel Gorman wrote: > On Tue, Sep 25, 2012 at 04:05:17PM +0900, Minchan Kim wrote: > > Hi Mel, > > > > I have a question below. > > > > On Fri, Sep 21, 2012 at 11:46:19AM +0100, Mel Gorman wrote: > > > Compactions migrate scanner acquires the zone->lru_lock

Re: [PATCH 5/9] mm: compaction: Acquire the zone->lru_lock as late as possible

2012-09-25 Thread Mel Gorman
On Tue, Sep 25, 2012 at 04:05:17PM +0900, Minchan Kim wrote: > Hi Mel, > > I have a question below. > > On Fri, Sep 21, 2012 at 11:46:19AM +0100, Mel Gorman wrote: > > Compactions migrate scanner acquires the zone->lru_lock when scanning a > > range > > of pages looking for LRU pages to acquire.

Re: [PATCH 5/9] mm: compaction: Acquire the zone->lru_lock as late as possible

2012-09-25 Thread Minchan Kim
Hi Mel, I have a question below. On Fri, Sep 21, 2012 at 11:46:19AM +0100, Mel Gorman wrote: > Compactions migrate scanner acquires the zone->lru_lock when scanning a range > of pages looking for LRU pages to acquire. It does this even if there are > no LRU pages in the range. If multiple process

Re: [PATCH 5/9] mm: compaction: Acquire the zone->lru_lock as late as possible

2012-09-21 Thread Rafael Aquini
On Fri, Sep 21, 2012 at 11:46:19AM +0100, Mel Gorman wrote: > Compactions migrate scanner acquires the zone->lru_lock when scanning a range > of pages looking for LRU pages to acquire. It does this even if there are > no LRU pages in the range. If multiple processes are compacting then this > can c