Re: [PATCH 5/9] usb: don't use PREPARE_DELAYED_WORK

2014-02-21 Thread Tejun Heo
On Fri, Feb 21, 2014 at 10:06:05AM -0500, Alan Stern wrote: > > I think it should be fine to use INIT_DELAYED_WORK(), but Alan would > > know best. Alan? > > That's right; INIT_DELAYED_WORK() should be fine. Provided there's no > problem doing it from within the previous work routine. Yeah, th

Re: [PATCH 5/9] usb: don't use PREPARE_DELAYED_WORK

2014-02-21 Thread Alan Stern
On Thu, 20 Feb 2014, Greg Kroah-Hartman wrote: > On Thu, Feb 20, 2014 at 03:44:27PM -0500, Tejun Heo wrote: > > PREPARE_[DELAYED_]WORK() are being phased out. They have few users > > and a nasty surprise in terms of reentrancy guarantee as workqueue > > considers work items to be different if the

Re: [PATCH 5/9] usb: don't use PREPARE_DELAYED_WORK

2014-02-20 Thread Greg Kroah-Hartman
On Thu, Feb 20, 2014 at 03:44:27PM -0500, Tejun Heo wrote: > PREPARE_[DELAYED_]WORK() are being phased out. They have few users > and a nasty surprise in terms of reentrancy guarantee as workqueue > considers work items to be different if they don't have the same work > function. > > usb_hub->ini