Re: [PATCH 56/74] lto, workaround: Add workaround for missing LTO symbols in igb

2012-08-22 Thread Andi Kleen
On Wed, Aug 22, 2012 at 08:43:35AM +, Arnd Bergmann wrote: > On Sunday 19 August 2012, Andi Kleen wrote: > > -static struct e1000_mac_operations e1000_mac_ops_82575 = { > > +/* Workaround for LTO bug */ > > +__visible struct e1000_mac_operations e1000_mac_ops_82575 = { > > The comment is not v

Re: [PATCH 56/74] lto, workaround: Add workaround for missing LTO symbols in igb

2012-08-22 Thread Arnd Bergmann
On Sunday 19 August 2012, Andi Kleen wrote: > -static struct e1000_mac_operations e1000_mac_ops_82575 = { > +/* Workaround for LTO bug */ > +__visible struct e1000_mac_operations e1000_mac_ops_82575 = { The comment is not very clear outside the context of this patch. Maybe change it to /* __visibl