Re: [PATCH 6/6] kasan: improve double-free reports.

2016-08-02 Thread Alexander Potapenko
On Mon, Aug 1, 2016 at 4:45 PM, Andrey Ryabinin wrote: > Currently we just dump stack in case of double free bug. > Let's dump all info about the object that we have. > > Signed-off-by: Andrey Ryabinin > --- > mm/kasan/kasan.c | 3 +-- > mm/kasan/kasan.h | 2 ++ > mm/kasan/report.c | 54

Re: [PATCH 6/6] kasan: improve double-free reports.

2016-08-02 Thread Andrey Ryabinin
On 08/02/2016 02:39 PM, Alexander Potapenko wrote: >> +static void kasan_end_report(unsigned long *flags) >> +{ >> + >> pr_err("==\n"); >> + add_taint(TAINT_BAD_PAGE, LOCKDEP_NOW_UNRELIABLE); > Don't we want to add the

Re: [PATCH 6/6] kasan: improve double-free reports.

2016-08-02 Thread Alexander Potapenko
On Tue, Aug 2, 2016 at 2:34 PM, Andrey Ryabinin wrote: > > > On 08/02/2016 02:39 PM, Alexander Potapenko wrote: > >>> +static void kasan_end_report(unsigned long *flags) >>> +{ >>> + >>> pr_err("==\n"); >>> + add_taint(TA

Re: [PATCH 6/6] kasan: improve double-free reports.

2016-08-02 Thread Alexander Potapenko
On Tue, Aug 2, 2016 at 1:39 PM, Alexander Potapenko wrote: > On Mon, Aug 1, 2016 at 4:45 PM, Andrey Ryabinin > wrote: >> Currently we just dump stack in case of double free bug. >> Let's dump all info about the object that we have. >> >> Signed-off-by: Andrey Ryabinin >> --- >> mm/kasan/kasan.