Re: [PATCH 6/8] pci: provide sensible irq vector alloc/free routines

2016-05-03 Thread Bjorn Helgaas
On Tue, May 03, 2016 at 11:19:46PM +0200, Christoph Hellwig wrote: > Hi Bjorn, > > I've implemented your suggestion and I'm getting ready to send out > a new version. One thing that came to mind is: do you prefer this > code in irq.c or would you rather have it in msi.c? While it > also has a l

Re: [PATCH 6/8] pci: provide sensible irq vector alloc/free routines

2016-05-03 Thread Christoph Hellwig
Hi Bjorn, I've implemented your suggestion and I'm getting ready to send out a new version. One thing that came to mind is: do you prefer this code in irq.c or would you rather have it in msi.c? While it also has a legacy irq fallback most of it tied pretty closely to the msi.c code, so I wonde

Re: [PATCH 6/8] pci: provide sensible irq vector alloc/free routines

2016-05-02 Thread Bjorn Helgaas
On Mon, May 02, 2016 at 04:42:03PM +0200, Christoph Hellwig wrote: > On Mon, May 02, 2016 at 08:11:24AM -0500, Bjorn Helgaas wrote: > > On Sun, May 01, 2016 at 08:01:49PM +0200, Christoph Hellwig wrote: > > > FYI, I spent some time trying to convert more drivers to this, and > > > I think we'll nee

Re: [PATCH 6/8] pci: provide sensible irq vector alloc/free routines

2016-05-02 Thread Christoph Hellwig
On Mon, May 02, 2016 at 08:11:24AM -0500, Bjorn Helgaas wrote: > On Sun, May 01, 2016 at 08:01:49PM +0200, Christoph Hellwig wrote: > > FYI, I spent some time trying to convert more drivers to this, and > > I think we'll need an additional flag to skip MSI or MSI-X as there > > is plenty of hardwar

Re: [PATCH 6/8] pci: provide sensible irq vector alloc/free routines

2016-05-02 Thread Bjorn Helgaas
On Sun, May 01, 2016 at 08:01:49PM +0200, Christoph Hellwig wrote: > FYI, I spent some time trying to convert more drivers to this, and > I think we'll need an additional flag to skip MSI or MSI-X as there > is plenty of hardware claiming support in the capabilities flag, > but not actually support

Re: [PATCH 6/8] pci: provide sensible irq vector alloc/free routines

2016-05-01 Thread Christoph Hellwig
On Fri, Apr 29, 2016 at 04:16:39PM -0500, Bjorn Helgaas wrote: > Sorry to be a pedant, but can you please edit the subject to be: > > PCI: Provide sensible IRQ vector alloc/free routines sure. > > so it matches the drivers/pci convention? > > I like this idea a lot. The MSI-X/MSI interfaces

Re: [PATCH 6/8] pci: provide sensible irq vector alloc/free routines

2016-04-29 Thread Bjorn Helgaas
[+cc Alexander] Sorry to be a pedant, but can you please edit the subject to be: PCI: Provide sensible IRQ vector alloc/free routines so it matches the drivers/pci convention? I like this idea a lot. The MSI-X/MSI interfaces are much better than they used to be, and I think this would be ano