Re: [PATCH 7/7] sysfs: @name comes before @ns

2013-09-26 Thread Greg KH
On Wed, Sep 11, 2013 at 11:49:43PM -0400, Tejun Heo wrote: > Hello, Eric. > > On Wed, Sep 11, 2013 at 08:39:27PM -0700, Eric W. Biederman wrote: > > @ns is more significant so it should come first. > > > > Where do we have the backwards convention of putting @name first? > > Because @ns is optio

Re: [PATCH 7/7] sysfs: @name comes before @ns

2013-09-11 Thread Tejun Heo
Hello, Eric. On Wed, Sep 11, 2013 at 08:39:27PM -0700, Eric W. Biederman wrote: > @ns is more significant so it should come first. > > Where do we have the backwards convention of putting @name first? Because @ns is optional and you end up with stupid stuff like sysfs_xxx_ns(@param, @ns

Re: [PATCH 7/7] sysfs: @name comes before @ns

2013-09-11 Thread Eric W. Biederman
Tejun Heo writes: > Some internal sysfs functions which take explicit namespace argument > are weird in that they place the optional @ns in front of @name which > is contrary to the established convention. This is confusing and > error-prone especially as @ns and @name may be interchanged withou