Re: [PATCH 7/8] cpufreq: st: Provide runtime initialised driver for ST's platforms

2015-06-24 Thread Lee Jones
On Tue, 23 Jun 2015, Paul Bolle wrote: > On Tue, 2015-06-23 at 09:28 +0100, Lee Jones wrote: > > BTW, do you have a script that does this now, or are you still > > hand-rolling these? > > There was a script detecting Kconfig problems that is basically > retired. (The messages I sent were always ma

Re: [PATCH 7/8] cpufreq: st: Provide runtime initialised driver for ST's platforms

2015-06-23 Thread Paul Bolle
On Tue, 2015-06-23 at 09:28 +0100, Lee Jones wrote: > BTW, do you have a script that does this now, or are you still > hand-rolling these? There was a script detecting Kconfig problems that is basically retired. (The messages I sent were always manually written.) That script's function is now perf

Re: [PATCH 7/8] cpufreq: st: Provide runtime initialised driver for ST's platforms

2015-06-23 Thread Lee Jones
On Tue, 23 Jun 2015, Viresh Kumar wrote: > On 23-06-15, 09:27, Lee Jones wrote: > > Okay, but the reasoning is the same. I consider the function to have > > failed, but the over-all failure culminates in just a warning that > > voltage scaling has indeed failed, but we can still go on with > > fr

Re: [PATCH 7/8] cpufreq: st: Provide runtime initialised driver for ST's platforms

2015-06-23 Thread Viresh Kumar
On 23-06-15, 09:27, Lee Jones wrote: > Okay, but the reasoning is the same. I consider the function to have > failed, but the over-all failure culminates in just a warning that > voltage scaling has indeed failed, but we can still go on with > frequency scaling. Ahh, I thought that the other opp-

Re: [PATCH 7/8] cpufreq: st: Provide runtime initialised driver for ST's platforms

2015-06-23 Thread Lee Jones
On Tue, 23 Jun 2015, Paul Bolle wrote: > On Mon, 2015-06-22 at 16:43 +0100, Lee Jones wrote: > > --- a/drivers/cpufreq/Kconfig.arm > > +++ b/drivers/cpufreq/Kconfig.arm > > > +config ARM_ST_CPUFREQ > > +> > bool "ST CPUFreq support" > > +> > depends on SOC_STIH407 > > +> > help > > +> > OP

Re: [PATCH 7/8] cpufreq: st: Provide runtime initialised driver for ST's platforms

2015-06-23 Thread Lee Jones
On Tue, 23 Jun 2015, Viresh Kumar wrote: > On 23-06-15, 08:16, Lee Jones wrote: > > Thanks for your timely review Viresh. > > Your welcome Lee :) > > > On Tue, 23 Jun 2015, Viresh Kumar wrote: > > > On 22-06-15, 16:43, Lee Jones wrote: > > > > +config ARM_ST_CPUFREQ > > > > + bool "ST CPUF

Re: [PATCH 7/8] cpufreq: st: Provide runtime initialised driver for ST's platforms

2015-06-23 Thread Viresh Kumar
On 23-06-15, 08:16, Lee Jones wrote: > Thanks for your timely review Viresh. Your welcome Lee :) > On Tue, 23 Jun 2015, Viresh Kumar wrote: > > On 22-06-15, 16:43, Lee Jones wrote: > > > +config ARM_ST_CPUFREQ > > > + bool "ST CPUFreq support" > > > > Isn't using ST just too generic? There are m

Re: [PATCH 7/8] cpufreq: st: Provide runtime initialised driver for ST's platforms

2015-06-23 Thread Paul Bolle
On Mon, 2015-06-22 at 16:43 +0100, Lee Jones wrote: > --- a/drivers/cpufreq/Kconfig.arm > +++ b/drivers/cpufreq/Kconfig.arm > +config ARM_ST_CPUFREQ > +>> bool "ST CPUFreq support" > +>> depends on SOC_STIH407 > +>> help > +>> OPP list for cpufreq-dt driver can be provided throu

Re: [PATCH 7/8] cpufreq: st: Provide runtime initialised driver for ST's platforms

2015-06-23 Thread Lee Jones
Thanks for your timely review Viresh. On Tue, 23 Jun 2015, Viresh Kumar wrote: > On 22-06-15, 16:43, Lee Jones wrote: > > +config ARM_ST_CPUFREQ > > + bool "ST CPUFreq support" > > Isn't using ST just too generic? There are multiple SoCs ST has been > involved with, I have worked on a completel

Re: [PATCH 7/8] cpufreq: st: Provide runtime initialised driver for ST's platforms

2015-06-22 Thread Viresh Kumar
On 22-06-15, 16:43, Lee Jones wrote: > +config ARM_ST_CPUFREQ > + bool "ST CPUFreq support" Isn't using ST just too generic? There are multiple SoCs ST has been involved with, I have worked on a completely different series. Probably a more relative string is required here, like stih407 ? > +