Re: [PATCH 7/8] thunderbolt: Add support for Intel Ice Lake

2019-08-05 Thread Mika Westerberg
On Sun, Aug 04, 2019 at 08:25:10PM +0200, Lukas Wunner wrote: > On Fri, Jul 05, 2019 at 12:57:59PM +0300, Mika Westerberg wrote: > > @@ -891,16 +1020,23 @@ static int nhi_resume_noirq(struct device *dev) > > { > > struct pci_dev *pdev = to_pci_dev(dev); > > struct tb *tb = pci_get_drvdata(

Re: [PATCH 7/8] thunderbolt: Add support for Intel Ice Lake

2019-08-04 Thread Lukas Wunner
On Fri, Jul 05, 2019 at 12:57:59PM +0300, Mika Westerberg wrote: > @@ -891,16 +1020,23 @@ static int nhi_resume_noirq(struct device *dev) > { > struct pci_dev *pdev = to_pci_dev(dev); > struct tb *tb = pci_get_drvdata(pdev); > + int ret; > + > + ret = nhi_power_up(tb->nhi); So

Re: [PATCH 7/8] thunderbolt: Add support for Intel Ice Lake

2019-07-05 Thread Yehezkel Bernat
On Fri, Jul 5, 2019 at 5:51 PM Mika Westerberg wrote: > > > > +static int nhi_suspend_power_down(struct tb *tb) > > > +{ > > > + int ret; > > > + > > > + /* > > > +* If there is no device connected we need to perform an > > > additional > > > +* handshake through LC ma

Re: [PATCH 7/8] thunderbolt: Add support for Intel Ice Lake

2019-07-05 Thread Mika Westerberg
On Fri, Jul 05, 2019 at 05:44:01PM +0300, Yehezkel Bernat wrote: > On Fri, Jul 5, 2019 at 12:58 PM Mika Westerberg > wrote: > > > > +static void icm_icl_rtd3_veto(struct tb *tb, const struct icm_pkg_header > > *hdr) > > +{ > > + const struct icm_icl_event_rtd3_veto *pkg = > > +

Re: [PATCH 7/8] thunderbolt: Add support for Intel Ice Lake

2019-07-05 Thread Yehezkel Bernat
On Fri, Jul 5, 2019 at 12:58 PM Mika Westerberg wrote: > > +static void icm_icl_rtd3_veto(struct tb *tb, const struct icm_pkg_header > *hdr) > +{ > + const struct icm_icl_event_rtd3_veto *pkg = > + (const struct icm_icl_event_rtd3_veto *)hdr; > + struct icm *icm = tb_pri