Re: [PATCH 7/8 v2] ARM OMAP2+ GPMC: calculate GPMCFCLKDIVIDER based on WAITMONITORINGTIME

2015-02-26 Thread Roger Quadros
Robert, On 25/02/15 19:20, Robert Abel wrote: > Hi Roger, > > On 25 Feb 2015 17:33, Roger Quadros wrote: >> ./scripts/checkpatch.pl detects some styling errors. > Well, there's like a million lines over 80 characters. I'm also a heathen and > don't use an 80 character terminal either. > I'll fix

Re: [PATCH 7/8 v2] ARM OMAP2+ GPMC: calculate GPMCFCLKDIVIDER based on WAITMONITORINGTIME

2015-02-25 Thread Robert Abel
On 25 Feb 2015 18:20, Roger Quadros wrote: Need to patch mach-omap2/usb-tusb6010.c as well. else we get arch/arm/mach-omap2/usb-tusb6010.c: In function ‘tusb_set_async_mode’: arch/arm/mach-omap2/usb-tusb6010.c:74:2: error: too few arguments to function ‘gpmc_cs_set_timings’ In file included fro

Re: [PATCH 7/8 v2] ARM OMAP2+ GPMC: calculate GPMCFCLKDIVIDER based on WAITMONITORINGTIME

2015-02-25 Thread Robert Abel
Hi Roger, On 25 Feb 2015 17:33, Roger Quadros wrote: ./scripts/checkpatch.pl detects some styling errors. Well, there's like a million lines over 80 characters. I'm also a heathen and don't use an 80 character terminal either. I'll fix the more serious issues checkpatch finds, but some styling

Re: [PATCH 7/8 v2] ARM OMAP2+ GPMC: calculate GPMCFCLKDIVIDER based on WAITMONITORINGTIME

2015-02-25 Thread Roger Quadros
Robert, On 25/02/15 18:33, Roger Quadros wrote: > On 24/02/15 22:05, Robert ABEL wrote: >> The WAITMONITORINGTIME is expressed as a number of GPMC_CLK clock cycles, >> even though the access is defined as asynchronous, and no GPMC_CLK clock >> is provided to the external device. Still, GPMCFCLKDIV

Re: [PATCH 7/8 v2] ARM OMAP2+ GPMC: calculate GPMCFCLKDIVIDER based on WAITMONITORINGTIME

2015-02-25 Thread Roger Quadros
On 24/02/15 22:05, Robert ABEL wrote: > The WAITMONITORINGTIME is expressed as a number of GPMC_CLK clock cycles, > even though the access is defined as asynchronous, and no GPMC_CLK clock > is provided to the external device. Still, GPMCFCLKDIVIDER is used as a > divider > for the GPMC clock, so