Re: [PATCH 7/9] afs: don't use PREPARE_WORK

2014-03-07 Thread Tejun Heo
On Thu, Feb 20, 2014 at 03:44:29PM -0500, Tejun Heo wrote: > PREPARE_[DELAYED_]WORK() are being phased out. They have few users > and a nasty surprise in terms of reentrancy guarantee as workqueue > considers work items to be different if they don't have the same work > function. > > afs_call->as

Re: [PATCH 7/9] afs: don't use PREPARE_WORK

2014-02-20 Thread Tejun Heo
On Thu, Feb 20, 2014 at 10:00:05PM +, David Howells wrote: > Tejun Heo wrote: > > > PREPARE_[DELAYED_]WORK() are being phased out. They have few users > > and a nasty surprise in terms of reentrancy guarantee as workqueue > > considers work items to be different if they don't have the same w

Re: [PATCH 7/9] afs: don't use PREPARE_WORK

2014-02-20 Thread David Howells
Tejun Heo wrote: > PREPARE_[DELAYED_]WORK() are being phased out. They have few users > and a nasty surprise in terms of reentrancy guarantee as workqueue > considers work items to be different if they don't have the same work > function. Why so? Isn't the work item address sufficient to disti