Re: [PATCH 78/89] sched/core: Remove the tsk_cpus_allowed() wrapper

2017-02-07 Thread Peter Zijlstra
On Mon, Feb 06, 2017 at 11:03:08PM +0100, Ingo Molnar wrote: > > * Peter Zijlstra wrote: > > > > +++ b/arch/powerpc/kernel/smp.c > > > +++ b/arch/sparc/kernel/sysfs.c > > > +++ b/drivers/cpufreq/sparc-us2e-cpufreq.c > > > +++ b/drivers/cpufreq/sparc-us3-cpufreq.c > > > > - cpumask_copy(&cpus_al

Re: [PATCH 78/89] sched/core: Remove the tsk_cpus_allowed() wrapper

2017-02-06 Thread Ingo Molnar
* Peter Zijlstra wrote: > > +++ b/arch/powerpc/kernel/smp.c > > +++ b/arch/sparc/kernel/sysfs.c > > +++ b/drivers/cpufreq/sparc-us2e-cpufreq.c > > +++ b/drivers/cpufreq/sparc-us3-cpufreq.c > > - cpumask_copy(&cpus_allowed, tsk_cpus_allowed(current)); > > + cpumask_copy(&cpus_allowed, ¤t->cp

Re: [PATCH 78/89] sched/core: Remove the tsk_cpus_allowed() wrapper

2017-02-06 Thread Peter Zijlstra
On Mon, Feb 06, 2017 at 02:29:21PM +0100, Ingo Molnar wrote: > diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c > index 54903862cf57..f40e2a5cf044 100644 > --- a/arch/powerpc/kernel/smp.c > +++ b/arch/powerpc/kernel/smp.c > @@ -796,7 +796,7 @@ void __init smp_cpus_done(unsigned in

Re: [PATCH 78/89] sched/core: Remove the tsk_cpus_allowed() wrapper

2017-02-06 Thread Peter Zijlstra
On Mon, Feb 06, 2017 at 02:29:21PM +0100, Ingo Molnar wrote: > So the original intention of tsk_cpus_allowed() was to 'future-proof' > the field - but it's pretty ineffectual at that, because half of > the code uses ->cpus_allowed directly ... > > Also, the wrapper makes the code longer than the o