On 25/02/15 19:22, Robert Abel wrote:
> Hi Roger,
>
> On 25 Feb 2015 18:17, Roger Quadros wrote:
>> How will the user know by looking at the kernel log that it was really an
>> error?
>> We don't fail probe if set_gpmc_timing_reg() fails so I feel it is necessary
>> to
>> clearly show an Error
Hi Roger,
On 25 Feb 2015 18:17, Roger Quadros wrote:
How will the user know by looking at the kernel log that it was really an error?
We don't fail probe if set_gpmc_timing_reg() fails so I feel it is necessary to
clearly show an Error message.
You can probably reword it like "%s: Error!! GPMC
Robert,
On 25/02/15 19:07, Robert Abel wrote:
> Hi Roger,
>
> On 25 Feb 2015 17:58, Roger Quadros wrote:
>>> static unsigned int gpmc_ticks_to_ps(unsigned int ticks)
>>> @@ -346,16 +395,22 @@ static void gpmc_cs_bool_timings(int cs, const struct
>>> gpmc_bool_timings *p)
>>>* @st_bit Start
Hi Roger,
On 25 Feb 2015 17:58, Roger Quadros wrote:
static unsigned int gpmc_ticks_to_ps(unsigned int ticks)
@@ -346,16 +395,22 @@ static void gpmc_cs_bool_timings(int cs, const struct
gpmc_bool_timings *p)
* @st_bit Start Bit
* @end_bit End Bit. Must be >= @st_bit.
* @nameDTS
Robert,
On 24/02/15 22:05, Robert ABEL wrote:
> The WAITMONITORINGTIME is expressed as a number of GPMC_CLK clock cycles,
> even though the access is defined as asynchronous, and no GPMC_CLK clock
> is provided to the external device. Still, GPMCFCLKDIVIDER is used as a
> divider
> for the GPMC
Robert,
On 24/02/15 22:05, Robert ABEL wrote:
The WAITMONITORINGTIME is expressed as a number of GPMC_CLK clock cycles,
even though the access is defined as asynchronous, and no GPMC_CLK clock
is provided to the external device. Still, GPMCFCLKDIVIDER is used as a
divider
for the GPMC
Hi Roger,
On 25 Feb 2015 18:17, Roger Quadros wrote:
How will the user know by looking at the kernel log that it was really an error?
We don't fail probe if set_gpmc_timing_reg() fails so I feel it is necessary to
clearly show an Error message.
You can probably reword it like %s: Error!! GPMC
Hi Roger,
On 25 Feb 2015 17:58, Roger Quadros wrote:
static unsigned int gpmc_ticks_to_ps(unsigned int ticks)
@@ -346,16 +395,22 @@ static void gpmc_cs_bool_timings(int cs, const struct
gpmc_bool_timings *p)
* @st_bit Start Bit
* @end_bit End Bit. Must be = @st_bit.
* @nameDTS
On 25/02/15 19:22, Robert Abel wrote:
Hi Roger,
On 25 Feb 2015 18:17, Roger Quadros wrote:
How will the user know by looking at the kernel log that it was really an
error?
We don't fail probe if set_gpmc_timing_reg() fails so I feel it is necessary
to
clearly show an Error message.
Robert,
On 25/02/15 19:07, Robert Abel wrote:
Hi Roger,
On 25 Feb 2015 17:58, Roger Quadros wrote:
static unsigned int gpmc_ticks_to_ps(unsigned int ticks)
@@ -346,16 +395,22 @@ static void gpmc_cs_bool_timings(int cs, const struct
gpmc_bool_timings *p)
* @st_bit Start Bit
*
10 matches
Mail list logo
