On Wed, 15 Oct 2014, Brian Norris wrote:
> On Thu, Oct 09, 2014 at 03:39:23PM +0100, Lee Jones wrote:
> > > > +static int check_erased_page(uint8_t *data, uint32_t page_size, int
> > > > max_zeros)
> > > > +{
> > > > + uint8_t *b = data;
> > > > + int zeros = 0;
> > > > + int i;
On Thu, Oct 09, 2014 at 03:39:23PM +0100, Lee Jones wrote:
> > > +static int check_erased_page(uint8_t *data, uint32_t page_size, int
> > > max_zeros)
> > > +{
> > > + uint8_t *b = data;
> > > + int zeros = 0;
> > > + int i;
> > > +
> > > + for (i = 0; i < page_size; i++) {
> > > + zeros +
> First off, this patch has several checkpatch warnings, some of which
> should be addressed:
Fixed.
> > +/* ONFI define 6 timing modes */
> > +#define ST_NAND_ONFI_TIMING_MODES 6
>
> This is unused?
Removed.
[...]
> > +static inline void bch_load_prog_cpu(struct nandi_controller *na
On Sun, 05 Oct 2014, Brian Norris wrote:
> On Wed, Aug 27, 2014 at 01:42:23PM +0100, Lee Jones wrote:
> > Reviewed-By: Pekon Gupta
> > Signed-off-by: Lee Jones
> > ---
> > drivers/mtd/nand/Kconfig|7 +
> > drivers/mtd/nand/Makefile |1 +
> > drivers/mtd/nand/stm_nand_bch.c
On Wed, Aug 27, 2014 at 01:42:23PM +0100, Lee Jones wrote:
> Reviewed-By: Pekon Gupta
> Signed-off-by: Lee Jones
> ---
> drivers/mtd/nand/Kconfig|7 +
> drivers/mtd/nand/Makefile |1 +
> drivers/mtd/nand/stm_nand_bch.c | 1616
> +++
> dr
Hi Lee,
First off, this patch has several checkpatch warnings, some of which
should be addressed:
WARNING: unnecessary whitespace before a quoted newline
#425: FILE: drivers/mtd/nand/stm_nand_bch.c:369:
+ "%s: erased page detected: \n"
WARNING: Possible unnecessary
6 matches
Mail list logo
