Re: [PATCH 9/9] fs: dlm: lockd: Convert int result to unsigned char type

2014-07-24 Thread Joe Perches
On Thu, 2014-07-24 at 12:24 -0400, Jeff Layton wrote: > On Wed, 23 Jul 2014 20:53:59 -0700 Joe Perches wrote: > > On Wed, 2014-07-23 at 14:11 -0400, Jeff Layton wrote: > > > On Sun, 20 Jul 2014 11:23:43 -0700 Joe Perches wrote: > > > > op->info.rv is an s32, but it's only used as a u8. > > > I do

Re: [PATCH 9/9] fs: dlm: lockd: Convert int result to unsigned char type

2014-07-24 Thread Jeff Layton
On Wed, 23 Jul 2014 20:53:59 -0700 Joe Perches wrote: > On Wed, 2014-07-23 at 14:11 -0400, Jeff Layton wrote: > > On Sun, 20 Jul 2014 11:23:43 -0700 Joe Perches wrote: > > > op->info.rv is an s32, but it's only used as a u8. > > I don't understand this patch. info.rv is s32 (and I assume that "r

Re: [PATCH 9/9] fs: dlm: lockd: Convert int result to unsigned char type

2014-07-23 Thread Joe Perches
On Wed, 2014-07-23 at 14:11 -0400, Jeff Layton wrote: > On Sun, 20 Jul 2014 11:23:43 -0700 Joe Perches wrote: > > op->info.rv is an s32, but it's only used as a u8. > I don't understand this patch. info.rv is s32 (and I assume that "rv" > stands for "return value"). In this case it's not a return

Re: [PATCH 9/9] fs: dlm: lockd: Convert int result to unsigned char type

2014-07-23 Thread David Teigland
On Wed, Jul 23, 2014 at 02:11:39PM -0400, Jeff Layton wrote: > On Sun, 20 Jul 2014 11:23:43 -0700 > Joe Perches wrote: > > > op->info.rv is an s32, but it's only used as a u8. > > > > I don't understand this patch. info.rv is s32 (and I assume that "rv" > stands for "return value"). What I don'

Re: [PATCH 9/9] fs: dlm: lockd: Convert int result to unsigned char type

2014-07-23 Thread Jeff Layton
On Sun, 20 Jul 2014 11:23:43 -0700 Joe Perches wrote: > op->info.rv is an s32, but it's only used as a u8. > I don't understand this patch. info.rv is s32 (and I assume that "rv" stands for "return value"). What I don't get is why you think it's just used as a u8. It seems to be used more like