Re: [PATCH 9/9] slab: remove a useless lockdep annotation

2014-02-23 Thread Joonsoo Kim
On Tue, Feb 18, 2014 at 10:21:10AM -0600, Christoph Lameter wrote: > On Mon, 17 Feb 2014, Joonsoo Kim wrote: > > > > Why change the BAD_ALIEN_MAGIC? > > > > Hello, Christoph. > > > > BAD_ALIEN_MAGIC is only checked by slab_set_lock_classes(). We remove this > > function in this patch, so returning

Re: [PATCH 9/9] slab: remove a useless lockdep annotation

2014-02-18 Thread Christoph Lameter
On Mon, 17 Feb 2014, Joonsoo Kim wrote: > > Why change the BAD_ALIEN_MAGIC? > > Hello, Christoph. > > BAD_ALIEN_MAGIC is only checked by slab_set_lock_classes(). We remove this > function in this patch, so returning BAD_ALIEN_MAGIC is useless. Its not useless. The point is if there is a pointer d

Re: [PATCH 9/9] slab: remove a useless lockdep annotation

2014-02-16 Thread Joonsoo Kim
On Fri, Feb 14, 2014 at 12:49:57PM -0600, Christoph Lameter wrote: > On Fri, 14 Feb 2014, Joonsoo Kim wrote: > > > @@ -921,7 +784,7 @@ static int transfer_objects(struct array_cache *to, > > static inline struct alien_cache **alloc_alien_cache(int node, > >

Re: [PATCH 9/9] slab: remove a useless lockdep annotation

2014-02-14 Thread Christoph Lameter
On Fri, 14 Feb 2014, Joonsoo Kim wrote: > @@ -921,7 +784,7 @@ static int transfer_objects(struct array_cache *to, > static inline struct alien_cache **alloc_alien_cache(int node, > int limit, gfp_t gfp) > { > - return (struct alien_cache **)BAD_A