Re: [PATCH RESEND] nfs: prevent truncate on active swapfile

2015-01-23 Thread Omar Sandoval
On Fri, Jan 23, 2015 at 08:07:41AM -0500, Trond Myklebust wrote: > On Thu, Jan 22, 2015 at 11:07 PM, Omar Sandoval wrote: > > On Mon, Jan 12, 2015 at 11:43:02AM -0800, Omar Sandoval wrote: > >> On Sat, Jan 10, 2015 at 05:08:03PM -0500, Trond Myklebust wrote: > >> > Hi Omar, > >> > > >> > On Thu, J

Re: [PATCH RESEND] nfs: prevent truncate on active swapfile

2015-01-23 Thread Trond Myklebust
On Thu, Jan 22, 2015 at 11:07 PM, Omar Sandoval wrote: > On Mon, Jan 12, 2015 at 11:43:02AM -0800, Omar Sandoval wrote: >> On Sat, Jan 10, 2015 at 05:08:03PM -0500, Trond Myklebust wrote: >> > Hi Omar, >> > >> > On Thu, Jan 8, 2015 at 4:18 AM, Omar Sandoval wrote: >> > > Most filesystems prevent

Re: [PATCH RESEND] nfs: prevent truncate on active swapfile

2015-01-22 Thread Omar Sandoval
On Mon, Jan 12, 2015 at 11:43:02AM -0800, Omar Sandoval wrote: > On Sat, Jan 10, 2015 at 05:08:03PM -0500, Trond Myklebust wrote: > > Hi Omar, > > > > On Thu, Jan 8, 2015 at 4:18 AM, Omar Sandoval wrote: > > > Most filesystems prevent truncation of an active swapfile by way of > > > inode_newsize

Re: [PATCH RESEND] nfs: prevent truncate on active swapfile

2015-01-12 Thread Omar Sandoval
On Sat, Jan 10, 2015 at 05:08:03PM -0500, Trond Myklebust wrote: > Hi Omar, > > On Thu, Jan 8, 2015 at 4:18 AM, Omar Sandoval wrote: > > Most filesystems prevent truncation of an active swapfile by way of > > inode_newsize_ok, called from inode_change_ok. NFS doesn't call either > > from nfs_seta

Re: [PATCH RESEND] nfs: prevent truncate on active swapfile

2015-01-10 Thread Trond Myklebust
Hi Omar, On Thu, Jan 8, 2015 at 4:18 AM, Omar Sandoval wrote: > Most filesystems prevent truncation of an active swapfile by way of > inode_newsize_ok, called from inode_change_ok. NFS doesn't call either > from nfs_setattr, presumably because most of these checks are expected > to be done server