Re: [PATCH RESEND 16/16] regulator: add LM363X driver

2015-11-09 Thread Kim, Milo
On 11/4/2015 10:59 PM, Mark Brown wrote: On Mon, Nov 02, 2015 at 02:24:35PM +0900, Milo Kim wrote: This looks mostly good, just a few fairly small things: +lm363x_regulator_of_get_init_data(struct device *dev, + struct lm363x_regulator *lm363x_regulator, int id) +{ +

Re: [PATCH RESEND 16/16] regulator: add LM363X driver

2015-11-04 Thread Mark Brown
On Mon, Nov 02, 2015 at 02:24:35PM +0900, Milo Kim wrote: This looks mostly good, just a few fairly small things: > +lm363x_regulator_of_get_init_data(struct device *dev, > + struct lm363x_regulator *lm363x_regulator, int id) > +{ > + struct device_node *np = dev->of_node;

Re: [PATCH RESEND 16/16] regulator: add LM363X driver

2015-11-02 Thread Kim, Milo
On 11/2/2015 9:26 PM, Mark Brown wrote: On Mon, Nov 02, 2015 at 02:24:35PM +0900, Milo Kim wrote: LM363X regulator driver supports LM3631 and LM3632. LM3631 has 5 regulators. LM3632 provides 3 regulators. One boost output and LDOs are used for the display module. Boost voltage is configurable bu

Re: [PATCH RESEND 16/16] regulator: add LM363X driver

2015-11-02 Thread Mark Brown
On Mon, Nov 02, 2015 at 02:24:35PM +0900, Milo Kim wrote: > LM363X regulator driver supports LM3631 and LM3632. > LM3631 has 5 regulators. LM3632 provides 3 regulators. > One boost output and LDOs are used for the display module. > Boost voltage is configurable but always on. > Supported operations