Re: [PATCH RESEND v4 00/37] mtd: st_spi_fsm: Add new driver

2014-02-14 Thread Lee Jones
> Sorry for the delay. I have now had a quick look through the patches. Just a > couple of points :-) > > * stfsm_probe(): stfsm_fetch_platform_configs() needs to be called *before* > config() -- config() is based on platform capabilities. Conceptually, > stfsm_fetch_platform_configs() should b

Re: [PATCH RESEND v4 00/37] mtd: st_spi_fsm: Add new driver

2014-02-11 Thread Angus Clark
Hi Lee, Sorry for the delay. I have now had a quick look through the patches. Just a couple of points :-) * stfsm_probe(): stfsm_fetch_platform_configs() needs to be called *before* config() -- config() is based on platform capabilities. Conceptually, stfsm_fetch_platform_configs() should be c