Re: [PATCH RFC] auxdisplay: charlcd: Fix and clean up handling of x/y commands

2018-02-27 Thread Miguel Ojeda
On Tue, Feb 27, 2018 at 9:52 PM, Andy Shevchenko wrote: > On Tue, Feb 27, 2018 at 9:32 PM, Miguel Ojeda > wrote: >> The current version is not parsing multiple x/y commands as the code >> originally intended. On top of that, kstrtoul() expects >> NULL-terminated strings. Finally, the code had to

Re: [PATCH RFC] auxdisplay: charlcd: Fix and clean up handling of x/y commands

2018-02-27 Thread Miguel Ojeda
On Tue, Feb 27, 2018 at 9:13 PM, Willy Tarreau wrote: > On Tue, Feb 27, 2018 at 08:32:21PM +0100, Miguel Ojeda wrote: >> The current version is not parsing multiple x/y commands as the code >> originally intended. On top of that, kstrtoul() expects >> NULL-terminated strings. Finally, the code had

Re: [PATCH RFC] auxdisplay: charlcd: Fix and clean up handling of x/y commands

2018-02-27 Thread Andy Shevchenko
On Tue, Feb 27, 2018 at 9:32 PM, Miguel Ojeda wrote: > The current version is not parsing multiple x/y commands as the code > originally intended. On top of that, kstrtoul() expects > NULL-terminated strings. Finally, the code had to do two passes over > the string, while now only one is done. > >

Re: [PATCH RFC] auxdisplay: charlcd: Fix and clean up handling of x/y commands

2018-02-27 Thread Willy Tarreau
On Tue, Feb 27, 2018 at 08:32:21PM +0100, Miguel Ojeda wrote: > The current version is not parsing multiple x/y commands as the code > originally intended. On top of that, kstrtoul() expects > NULL-terminated strings. Finally, the code had to do two passes over > the string, while now only one is d