Re: [PATCH RFC 1/1] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-11-07 Thread Lina Iyer
On Mon, Nov 05 2018 at 22:19 -0700, Stephen Boyd wrote: Quoting Lina Iyer (2018-11-01 10:16:30) On Wed, Oct 31 2018 at 18:13 -0600, Stephen Boyd wrote: > [...] Ok. I don't see why we need to limit ourselves here. If a GPIO interrupt isn't routed through PDC physically why does it matter? It s

Re: [PATCH RFC 1/1] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-11-05 Thread Stephen Boyd
Quoting Lina Iyer (2018-11-01 10:16:30) > On Wed, Oct 31 2018 at 18:13 -0600, Stephen Boyd wrote: > > > >Right. Let's scrap the plan to do the wakeup based mask/unmask in both > >chips. It won't work because of the edge trigger type. > > > >The difference I see is that this patch does the irq "forw

Re: [PATCH RFC 1/1] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-11-01 Thread Lina Iyer
On Wed, Oct 31 2018 at 18:13 -0600, Stephen Boyd wrote: Quoting Lina Iyer (2018-10-31 09:46:50) On Wed, Oct 31 2018 at 01:05 -0600, Stephen Boyd wrote: >Hi Lina, > >Quoting Lina Iyer (2018-10-10 17:29:58) >> QCOM SoC's that have Power Domain Controller (PDC) chip in the always-on >> domain can w

Re: [PATCH RFC 1/1] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-10-31 Thread Stephen Boyd
Quoting Lina Iyer (2018-10-31 09:46:50) > On Wed, Oct 31 2018 at 01:05 -0600, Stephen Boyd wrote: > >Hi Lina, > > > >Quoting Lina Iyer (2018-10-10 17:29:58) > >> QCOM SoC's that have Power Domain Controller (PDC) chip in the always-on > >> domain can wakeup the SoC, when interrupts and GPIOs are ro

Re: [PATCH RFC 1/1] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-10-31 Thread Lina Iyer
On Wed, Oct 31 2018 at 01:05 -0600, Stephen Boyd wrote: Hi Lina, Quoting Lina Iyer (2018-10-10 17:29:58) QCOM SoC's that have Power Domain Controller (PDC) chip in the always-on domain can wakeup the SoC, when interrupts and GPIOs are routed to its interrupt controller. Only select GPIOs that a

Re: [PATCH RFC 1/1] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-10-31 Thread Lina Iyer
On Wed, Oct 31 2018 at 01:05 -0600, Stephen Boyd wrote: Hi Lina, Quoting Lina Iyer (2018-10-10 17:29:58) QCOM SoC's that have Power Domain Controller (PDC) chip in the always-on domain can wakeup the SoC, when interrupts and GPIOs are routed to its interrupt controller. Only select GPIOs that a

Re: [PATCH RFC 1/1] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-10-31 Thread Stephen Boyd
Hi Lina, Quoting Lina Iyer (2018-10-10 17:29:58) > QCOM SoC's that have Power Domain Controller (PDC) chip in the always-on > domain can wakeup the SoC, when interrupts and GPIOs are routed to its > interrupt controller. Only select GPIOs that are deemed wakeup capable > are routed to specific PDC

Re: [PATCH RFC 1/1] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-10-24 Thread Lina Iyer
On Mon, Oct 22 2018 at 03:27 -0600, Marc Zyngier wrote: On Fri, 19 Oct 2018 20:47:12 +0100, Lina Iyer wrote: On Fri, Oct 19 2018 at 09:53 -0600, Marc Zyngier wrote: > Hi Lina, > > On 19/10/18 16:32, Lina Iyer wrote: >> Hi folks, >> >> On Wed, Oct 10 2018 at 18:30 -0600, Lina Iyer wrote: [...]

Re: [PATCH RFC 1/1] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-10-22 Thread Marc Zyngier
On Fri, 19 Oct 2018 20:47:12 +0100, Lina Iyer wrote: > > On Fri, Oct 19 2018 at 09:53 -0600, Marc Zyngier wrote: > > Hi Lina, > > > > On 19/10/18 16:32, Lina Iyer wrote: > >> Hi folks, > >> > >> On Wed, Oct 10 2018 at 18:30 -0600, Lina Iyer wrote: > > [...] > > >>> +static irqreturn_t wake_ir

Re: [PATCH RFC 1/1] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-10-19 Thread Lina Iyer
On Fri, Oct 19 2018 at 09:53 -0600, Marc Zyngier wrote: Hi Lina, On 19/10/18 16:32, Lina Iyer wrote: Hi folks, On Wed, Oct 10 2018 at 18:30 -0600, Lina Iyer wrote: [...] +static irqreturn_t wake_irq_gpio_handler(int irq, void *data) +{ + struct irq_data *irqd = data; + struct i

Re: [PATCH RFC 1/1] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-10-19 Thread Marc Zyngier
Hi Lina, On 19/10/18 16:32, Lina Iyer wrote: > Hi folks, > > On Wed, Oct 10 2018 at 18:30 -0600, Lina Iyer wrote: >> QCOM SoC's that have Power Domain Controller (PDC) chip in the always-on >> domain can wakeup the SoC, when interrupts and GPIOs are routed to its >> interrupt controller. Only sel

Re: [PATCH RFC 1/1] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-10-19 Thread Lina Iyer
Hi folks, On Wed, Oct 10 2018 at 18:30 -0600, Lina Iyer wrote: QCOM SoC's that have Power Domain Controller (PDC) chip in the always-on domain can wakeup the SoC, when interrupts and GPIOs are routed to its interrupt controller. Only select GPIOs that are deemed wakeup capable are routed to spec