Re: [PATCH RFC 2/2] IB/hfi1: Fix port ordering issue in a multiport device

2017-02-07 Thread Greg KH
On Mon, Feb 06, 2017 at 01:04:25PM -0800, Christoph Hellwig wrote: > On Mon, Feb 06, 2017 at 12:26:42PM -0700, Jason Gunthorpe wrote: > > Still no on this from me, this is a horrible abuse of the device core. > > Seconded. Netdevice (and thus RDMA) devices names generated by the > kernel are not

Re: [PATCH RFC 2/2] IB/hfi1: Fix port ordering issue in a multiport device

2017-02-06 Thread Christoph Hellwig
On Mon, Feb 06, 2017 at 12:26:42PM -0700, Jason Gunthorpe wrote: > Still no on this from me, this is a horrible abuse of the device core. Seconded. Netdevice (and thus RDMA) devices names generated by the kernel are not stable, period. Use udev and the MAC / port GUID or whatever the OFI equival

Re: [PATCH RFC 2/2] IB/hfi1: Fix port ordering issue in a multiport device

2017-02-06 Thread Jason Gunthorpe
On Mon, Feb 06, 2017 at 11:15:33AM -0800, Tadeusz Struk wrote: > Some hardware has multiple HFIs within the same ASIC, each one on a > sepatate bus number. In some devices the numbers labeled on the > faceplate of the device don't match the PCI bus order, and the result > is that the devices (ports